Starting to add doxygen, moved FindNetCDF.cmake and FindESMF.cmake into project, edit README #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can wait until #187 is merged... |
|
@edwardhartnett When I clone your branch, I see a zero byte .gitmodules file. And I see an empty CMakeModules directory. All package finds are now under ./cmake. So can the first two items be removed? |
|
@GeorgeGayno-NOAA good question! I will investigate and remove them if it works... |
|
@GeorgeGayno-NOAA I think this is ready to merge. |
config files are now in ./cmake. Issue #191
|
I was able to remove empty directory CMakeModules with no impact. |
|
The branch at 60f7d34 at successfully compiled on WCOSS-Dell, WCOSS-Cray, Hera and Orion. It failed on Jet, because I am pointing to Dom's NCEPLIBS. And he recently renamed and removed his directories. So the failure is not due to changes under this PR. Will merge. |
GeorgeGayno-NOAA
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #171
Fixes #190
Part of #191
Dealing with submodule, starting to add docs.