Add GPU project chipyard changes #2190
Conversation
Includes GPR_RESET which uses simulation-only initial block to clear out regfile.
common.mk
Outdated
| @@ -233,6 +236,7 @@ $(TOP_SMEMS_CONF) $(MODEL_SMEMS_CONF) &: $(MFC_SMEMS_CONF) $(MFC_MODEL_HRCHY_JS | |||
| --model-module-name $(MODEL) \ | |||
| --out-dut-smems-conf $(TOP_SMEMS_CONF) \ | |||
| --out-model-smems-conf $(MODEL_SMEMS_CONF) | |||
| cat $(base_dir)/vlsi/add.mems.conf >> $(TOP_SMEMS_CONF) | |||
There was a problem hiding this comment.
ah i had a comment here, somehow missed it and didnt push. updated, it's for the srams we use inside of vortex
conda-reqs/chipyard-extended.yaml
Outdated
| @@ -46,6 +46,9 @@ dependencies: | |||
| - findutils | |||
| - lzop | |||
|
|
|||
| # dpi module | |||
| - rust | |||
There was a problem hiding this comment.
🦀 . I believe you'll need to regenerate the lockfile too
There was a problem hiding this comment.
ope I don't think we want this in here just yet
| import org.chipsalliance.cde.config.Config | ||
| import radiance.subsystem.RadianceGemminiDataType | ||
|
|
||
| class WithRadBootROM(address: BigInt = 0x10000, size: Int = 0x10000, hang: BigInt = 0x10100) extends Config((site, here, up) => { |
There was a problem hiding this comment.
Move this to the right file in config/fragments.
Also maybe we can merge this one first: chipsalliance/rocket-chip#3699? That will allow SoCs with multiple ROMs (one for normal core, and one for GPU cores).
| @@ -38,4 +38,5 @@ SIM_PREPROC_DEFINES = \ | |||
| +define+RANDOMIZE_MEM_INIT \ | |||
| +define+RANDOMIZE_REG_INIT \ | |||
| +define+RANDOMIZE_GARBAGE_ASSIGN \ | |||
| +define+RANDOMIZE_INVALID_ASSIGN | |||
| +define+RANDOMIZE_INVALID_ASSIGN \ | |||
| $(EXTRA_SIM_PREPROC_DEFINES) | |||
There was a problem hiding this comment.
Add this to HELP_COMPILATION_VARIABLES in common.mk
| @@ -151,3 +151,6 @@ | |||
| [submodule "generators/vexiiriscv"] | |||
| path = generators/vexiiriscv | |||
| url = https://github.com/ucb-bar/vexiiriscv-tile.git | |||
| [submodule "generators/radiance"] | |||
There was a problem hiding this comment.
You should add radiance to the .github/scripts/check-commit.sh script
| new freechips.rocketchip.subsystem.WithNBanks(4) ++ | ||
| new chipyard.config.WithSystemBusWidth(16 * 8) ++ | ||
| // Small Rocket core that does nothing | ||
| new radiance.subsystem.WithNCustomSmallRocketCores(1) ++ |
There was a problem hiding this comment.
Can you just remove the cores? I think that should be supported (Look at NoCoresConfig).
@hansungk's changes
Didn't mean to change that, will revert |
|
run-binaries-debug-bg makes sure the compile stage before sim is serialized. Was mostly for personal use though, we can leave it out |
Hmm, the Makefile dependencies should already be enforcing compile ahead of sim... unless there's something which the Makefile isn't aware of that is a dependency. |
|
Yep, it's just that if you kick off many run-binaries-debug &, they might compile the same thing concurrently and might mangle some states. was mostly used for same config but different binary launches |
Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
mainas the base branch?changelog:<topic>label?changelog:label?.conda-lock.ymlfile if you updated the conda requirements file?Please Backport?CI Help:
Add the following labels to modify the CI for a set of features.
Generally, a label added only affect subsequent changes to the PR (i.e. new commits, force pushing, closing/reopening).
See
ci:*for full list of labels:ci:fpga-deploy- Run FPGA-based E2E testingci:local-fpga-buildbitstream-deploy- Build local FPGA bitstreams for platforms that are releasedci:disable- Disable CI