Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migrate): improve acl->authz migration, remove deprecated endpoints #336

Merged
merged 6 commits into from
Sep 28, 2022

Conversation

Avantol13
Copy link
Contributor

@Avantol13 Avantol13 commented Sep 19, 2022

…fence configuration

New Features

Breaking Changes

  • Ensure you are using Fence>=2021.10. Remove deprecated GA4GH access endpoints. these have existed (and been used) from the Fence microservice since last year. See cloud automation change here

Bug Fixes

Improvements

  • allow passing of fence config for authz mapping to the acl migration script

Dependency updates

Deployment changes

@github-actions
Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@Avantol13 Avantol13 changed the title fix(migrate_acl): allow loading and preference of authz mapping from … fix(migrate): improve acl->authz migration, remove deprecated endpoints Sep 19, 2022
@Avantol13 Avantol13 merged commit 98146f5 into master Sep 28, 2022
@Avantol13 Avantol13 deleted the fix/migrate_acl branch September 28, 2022 14:57
@Avantol13
Copy link
Contributor Author

Merged knowing that GetCoreMetadata test is failing. It's unrelated to these changes and a known issue that is being debugged. Likely a portal fix is necessary.

Avantol13 added a commit that referenced this pull request Dec 7, 2022
#338)

* Revert "Revert "fix(migrate): improve acl->authz migration, remove deprecated endpoints (#336)" (#337)"

This reverts commit 6d7b337.

* fix(routing): reorder blueprint routes to accommodate new version of web framework

* fix(migration): ensure if a valid authz path is found for any acl, we move on

* fix(migration): ensure if a valid authz path is found for any acl, we move on

* Update migrate_acl_authz.py

* Update migrate_acl_authz.py

Co-authored-by: Alexander VT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants