Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploying qa-brh.planx-pla.net - 2022.09 1665512168 #2226

Merged

Conversation

PlanXCyborg
Copy link
Contributor

Applying version 2022.09 to qa-brh.planx-pla.net

@PlanXCyborg PlanXCyborg added the gen3-release Enable additional tests and automation label Oct 11, 2022
@PlanXCyborg
Copy link
Contributor Author

qa-brh.planx-pla.net/manifest.json

Deployment changes

Breaking changes

  • fence
    • Default session expiration changed from 30 minutes to 15 minutes to comply with FedRAMP (feat(session): change default to 15 minutes [PPS-122] fence#1040)
    • URL Signing when no_force_sign query param is provided: Previously Fence would make a decision based off if the data was public and no_force_sign provided. Fence will now NEVER sign if no_force_sign is provided (since the concept of "public" data has been abstracted out of Fence. Data access - public or not - is the sole responsibility of the policy engine). In other words, if no_force_sign is provided at the API level, Fence will respect that regardless of whether the resulting URL will actually work. The default Fence behavior should remain the same. chore/update dd version to 3.6.0 #988 (Feat/passport fence#964)
  • indexd

@atharvar28 atharvar28 requested review from nss10 and aartivnkt and removed request for nss10 October 11, 2022 18:32
@@ -11,7 +11,7 @@
"sidecar": {
"cpu-limit": "1.0",
"memory-limit": "256Mi",
"image": "quay.io/cdis/ecs-ws-sidecar:feat_datamounting",
"image": "quay.io/cdis/ecs-ws-sidecar:2022.09",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if feat_datamounting image is needed for hatchery. @jmontmaxwell do you know about this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the ecs-ws-sidecar history it looks like feat_datamounting was merged in May2022 so I think we should be fine @aartivnkt

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

nss10
nss10 previously approved these changes Oct 11, 2022
@PlanXCyborg PlanXCyborg added test-apis-dbgapTest test-apis-userTokenTest and removed gen3-release Enable additional tests and automation labels Oct 11, 2022
@PlanXCyborg
Copy link
Contributor Author

qa-brh.planx-pla.net/manifest.json

Deployment changes

Breaking changes

  • fence
    • Default session expiration changed from 30 minutes to 15 minutes to comply with FedRAMP (feat(session): change default to 15 minutes [PPS-122] fence#1040)
    • URL Signing when no_force_sign query param is provided: Previously Fence would make a decision based off if the data was public and no_force_sign provided. Fence will now NEVER sign if no_force_sign is provided (since the concept of "public" data has been abstracted out of Fence. Data access - public or not - is the sole responsibility of the policy engine). In other words, if no_force_sign is provided at the API level, Fence will respect that regardless of whether the resulting URL will actually work. The default Fence behavior should remain the same. chore/update dd version to 3.6.0 #988 (Feat/passport fence#964)
  • indexd

@PlanXCyborg
Copy link
Contributor Author

qa-brh.planx-pla.net/manifest.json

Deployment changes

Breaking changes

  • fence
    • Default session expiration changed from 30 minutes to 15 minutes to comply with FedRAMP (feat(session): change default to 15 minutes [PPS-122] fence#1040)
    • URL Signing when no_force_sign query param is provided: Previously Fence would make a decision based off if the data was public and no_force_sign provided. Fence will now NEVER sign if no_force_sign is provided (since the concept of "public" data has been abstracted out of Fence. Data access - public or not - is the sole responsibility of the policy engine). In other words, if no_force_sign is provided at the API level, Fence will respect that regardless of whether the resulting URL will actually work. The default Fence behavior should remain the same. chore/update dd version to 3.6.0 #988 (Feat/passport fence#964)
  • indexd

@aartivnkt aartivnkt merged commit 8f2c05a into master Oct 12, 2022
@aartivnkt aartivnkt deleted the chore/apply_202209_to_qa-brh_planx-pla_net_1665512169 branch October 12, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants