Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(google_update): updated Flask and deps, also don't fail early with Google errors PXP-10900 #1086

Merged
merged 16 commits into from
May 4, 2023

Conversation

Avantol13
Copy link
Contributor

@Avantol13 Avantol13 commented Apr 14, 2023

Depends on:
uc-cdis/userdatamodel#77
uc-cdis/gen3config#21

New Features

Breaking Changes

  • Removed most Prometheus support

Bug Fixes

Improvements

  • Remove out of date Flask SQLAlchemy session handling library and refactor session management to use a recommended pure Flask + SQLAlchemy approach that is thread-safe

Dependency updates

  • Update to next major version of Flask, alongside many other updates to support that
  • Update to latest Werkzeug for security

Deployment changes

@k-burt-uch k-burt-uch self-requested a review April 14, 2023 18:49
k-burt-uch
k-burt-uch previously approved these changes Apr 14, 2023
@coveralls
Copy link

coveralls commented Apr 14, 2023

Pull Request Test Coverage Report for Build 13513

  • 89 of 129 (68.99%) changed or added relevant lines in 23 files are covered.
  • 7 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.01%) to 74.356%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fence/blueprints/storage_creds/init.py 1 2 50.0%
fence/sync/sync_users.py 8 9 88.89%
fence/blueprints/register.py 1 3 33.33%
fence/blueprints/storage_creds/google.py 1 3 33.33%
fence/oidc/jwt_generator.py 3 5 60.0%
fence/blueprints/link.py 2 6 33.33%
fence/blueprints/user.py 1 6 16.67%
fence/resources/google/utils.py 12 20 60.0%
fence/blueprints/admin.py 6 21 28.57%
Files with Coverage Reduction New Missed Lines %
fence/blueprints/admin.py 1 71.9%
fence/resources/openid/ras_oauth2.py 1 58.96%
fence/scripting/fence_create.py 1 60.18%
fence/resources/ga4gh/passports.py 2 87.43%
fence/resources/google/validity.py 2 88.1%
Totals Coverage Status
Change from base Build 13501: 0.01%
Covered Lines: 7156
Relevant Lines: 9624

💛 - Coveralls

…gathered by external tools by logs and not embedded into services
…nagement library with recommended session strategies, fix other deprecated/removed features
@Avantol13 Avantol13 changed the title fix(google_update): don't fail early with Google errors (try to conti… feat(google_update): updated Flask and deps, also don't fail early with Google errors Apr 18, 2023
@Avantol13 Avantol13 changed the title feat(google_update): updated Flask and deps, also don't fail early with Google errors feat(google_update): updated Flask and deps, also don't fail early with Google errors PXP-10900 Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants