Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/vadc defect20 unlabeled3 button #1603

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Bugfix/vadc defect20 unlabeled3 button #1603

merged 3 commits into from
Oct 9, 2024

Conversation

jarvisraymond-uchicago
Copy link
Contributor

@jarvisraymond-uchicago jarvisraymond-uchicago commented Oct 8, 2024 •
edited
Loading

Link to JIRA ticket if there is one:
https://ctds-planx.atlassian.net/browse/VADC-1440

Dev Notes

  • Changes span with role=button to button element, user can now tab to button and trigger it with keyboard
  • Adds aria-label "Change Team Project" to button
  • Removes unneeded SVG role attribute for button on icon
    output

Bug Fixes

Addresses accessibility issues related to the team projects button in VADC apps.

@jarvisraymond-uchicago jarvisraymond-uchicago marked this pull request as ready for review October 8, 2024 17:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

filepath $$\textcolor{#23d18b}{\tt{passed}}$$ $$\textcolor{#ffa500}{\tt{skipped}}$$ SUBTOTAL
$$\textcolor{#23d18b}{\tt{tests/test\_requestor.py}}$$ $$\textcolor{#23d18b}{\tt{5}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#23d18b}{\tt{5}}$$
$$\textcolor{#23d18b}{\tt{tests/test\_ras\_authn.py}}$$ $$\textcolor{#23d18b}{\tt{3}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#23d18b}{\tt{3}}$$
$$\textcolor{#23d18b}{\tt{tests/test\_login\_page.py}}$$ $$\textcolor{#23d18b}{\tt{2}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#23d18b}{\tt{2}}$$
$$\textcolor{#23d18b}{\tt{tests/test\_data\_upload.py}}$$ $$\textcolor{#23d18b}{\tt{2}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#23d18b}{\tt{2}}$$
$$\textcolor{#23d18b}{\tt{tests/test\_audit\_service.py}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{tests/test\_indexing\_page.py}}$$ $$\textcolor{#23d18b}{\tt{2}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#23d18b}{\tt{2}}$$
$$\textcolor{#23d18b}{\tt{tests/test\_homepage.py}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{tests/test\_pfb\_export.py}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{tests/test\_discoverypage.py}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{tests/test\_graph\_submit\_and\_query.py}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#ffa500}{\tt{tests/test\_gen3ff\_landing\_page.py}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#ffa500}{\tt{2}}$$ $$\textcolor{#ffa500}{\tt{2}}$$
$$\textcolor{#ffa500}{\tt{tests/test\_register\_user.py}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#ffa500}{\tt{2}}$$ $$\textcolor{#ffa500}{\tt{2}}$$
$$\textcolor{#ffa500}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{19}}$$ $$\textcolor{#ffa500}{\tt{4}}$$ $$\textcolor{#ffa500}{\tt{23}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

cemile-ctds
cemile-ctds approved these changes Oct 9, 2024
View reviewed changes
Copy link

@cemile-ctds cemile-ctds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good on my side.

@jarvisraymond-uchicago jarvisraymond-uchicago merged commit e68742c into feat/vadc_sprint20 Oct 9, 2024
10 checks passed
@jarvisraymond-uchicago jarvisraymond-uchicago deleted the bugfix/vadcDefect20Unlabeled3Button branch October 9, 2024 19:48
jarvisraymond-uchicago added a commit that referenced this pull request Oct 23, 2024
@jarvisraymond-uchicago @ocshawn
Feat/vadc sprint20 (#1610)
7d03acf 
* Bugfix/vadc defect20 unlabeled3 button (#1603)

* PPS-1564 PPS-1567 PPS-1585: update guppy to 0.19.1 (#1601)

* bugfix(vadcDefect20Unlabled3Button): initial commit

* bugfix(vadcDefect20Unlabled3Button): reverted unintentionally changed files

---------

Co-authored-by: Shawn O'Connor <[email protected]>

* Feat/attrition table histogram modal (#1600)

* feat(attritionTableHistogramModel): Initial commit

* feat(attritionTableHistogramModal): Initial commit

* feat(attritionTableHistogramModal): added CSS, notes for technical approach, func to determine modal title

* feat(attritionTableHistogramModal): Ran linter, reverted unintentionally changed file

* feat(attritionTableHistogramModal): Data wrangled needed props for histogram into modal

* feat(attritionTableHistogramModal): Ran linter

* feat(attritionTableHistogramModal): Added logic to render histogram and display messages inline, added styles for modal

* feat(attritionTableHistogramModal): updated to use currentCovariateAndCovariatesFromPrecedingRows instead of covariates, ran linter

* feat(attritionaTableHistogramModal): updated storybook

* feat(attritionaTableHistogramModal): code cleanup - remove dev notes file, unneeded vars

* feat(attritionaTableHistogramModal): code cleanup - removed unneeded dispatch var

* feat(attritionaTableHistogramModal): code cleanup - changed order of propTypes object keys

* feat(attritionTableHistogramModal): Wrote unit test

* feat(attritionTableHistogramModal): ran linter

* feat(attritionTableHistogramModal): refactored unit test

* feat(attritionTableHistogramModal): added logic for euler diagram viz

* feat(attritionTableHistogramModal): added logic for euler diagram, updated unit tests

* feat(attritionTableHistogramModal): updated stories to show euler diagrams

* feat(attritionTableHistogramModal): updated stories to render euler diagrams that actually show diagram

* feat(attritionTableHistogramModal): code cleanup - removal of unneeded log statements and vars

* feat(attritionTableHistogramModal: ran eslint

* feat(attritionTableHistogramModal): Formatted code, added aria label to button

* feat(attritionTableHistogram): ran linter

* feat(attritionTableHistogram): ran linter

* feat(attritionTableHistogramModal): added prop and logic to disenable animation on histogram in modals

* feat(attritionTableHistogramModal): updated comments, ran linter

* feat(attritionTableHistogramModal): updated comment

* feat(attritionTableHistogramModal): removed unneeded file

* feat(attritionTableHistogramModal): added variable rowIsOutcome

* feat(attritionTableHistogramModal): ran linter and fixed spelling mistake in variable name

* feat(attritionTableHistogramModal): added default values for AttritionTableRow modalInfo obj and func, added code to try to force re-draws of viz

* feat(attritionTableHistogramModal): Ran linter, removed unneeded props from first row AttritionTableRow

* feat(attritionTableHistogramModal): Removed duplicate modal and hoisted existing modal to be a child of AttritionTableWrapper to try to resolve issue with outcome diagram not re-drawing

* feat(attritionTableHistogramModal): updated conditional for determining rowIsOutcome to use rowType string

* feat(attritionTableHistogramModal): ran linter

* feat(attritionTableHistogramModal): Updated ID ref used by Euler diagram in D3 call to be dynamic to avoid unexpected re-rendering

---------

Co-authored-by: Shawn O'Connor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cemile-ctds cemile-ctds cemile-ctds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jarvisraymond-uchicago @cemile-ctds @ocshawn