(PPS-1564 PPS-1567 PPS-1585): update guppy to 0.19.1 #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfshao
approved these changes
Oct 7, 2024
Please find the detailed integration test report here Please find the ci env pod logs here |
jarvisraymond-uchicago
added a commit
that referenced
this pull request
Oct 9, 2024
* PPS-1564 PPS-1567 PPS-1585: update guppy to 0.19.1 (#1601) * bugfix(vadcDefect20Unlabled3Button): initial commit * bugfix(vadcDefect20Unlabled3Button): reverted unintentionally changed files --------- Co-authored-by: Shawn O'Connor <[email protected]>
jarvisraymond-uchicago
added a commit
that referenced
this pull request
Oct 23, 2024
* Bugfix/vadc defect20 unlabeled3 button (#1603) * PPS-1564 PPS-1567 PPS-1585: update guppy to 0.19.1 (#1601) * bugfix(vadcDefect20Unlabled3Button): initial commit * bugfix(vadcDefect20Unlabled3Button): reverted unintentionally changed files --------- Co-authored-by: Shawn O'Connor <[email protected]> * Feat/attrition table histogram modal (#1600) * feat(attritionTableHistogramModel): Initial commit * feat(attritionTableHistogramModal): Initial commit * feat(attritionTableHistogramModal): added CSS, notes for technical approach, func to determine modal title * feat(attritionTableHistogramModal): Ran linter, reverted unintentionally changed file * feat(attritionTableHistogramModal): Data wrangled needed props for histogram into modal * feat(attritionTableHistogramModal): Ran linter * feat(attritionTableHistogramModal): Added logic to render histogram and display messages inline, added styles for modal * feat(attritionTableHistogramModal): updated to use currentCovariateAndCovariatesFromPrecedingRows instead of covariates, ran linter * feat(attritionaTableHistogramModal): updated storybook * feat(attritionaTableHistogramModal): code cleanup - remove dev notes file, unneeded vars * feat(attritionaTableHistogramModal): code cleanup - removed unneeded dispatch var * feat(attritionaTableHistogramModal): code cleanup - changed order of propTypes object keys * feat(attritionTableHistogramModal): Wrote unit test * feat(attritionTableHistogramModal): ran linter * feat(attritionTableHistogramModal): refactored unit test * feat(attritionTableHistogramModal): added logic for euler diagram viz * feat(attritionTableHistogramModal): added logic for euler diagram, updated unit tests * feat(attritionTableHistogramModal): updated stories to show euler diagrams * feat(attritionTableHistogramModal): updated stories to render euler diagrams that actually show diagram * feat(attritionTableHistogramModal): code cleanup - removal of unneeded log statements and vars * feat(attritionTableHistogramModal: ran eslint * feat(attritionTableHistogramModal): Formatted code, added aria label to button * feat(attritionTableHistogram): ran linter * feat(attritionTableHistogram): ran linter * feat(attritionTableHistogramModal): added prop and logic to disenable animation on histogram in modals * feat(attritionTableHistogramModal): updated comments, ran linter * feat(attritionTableHistogramModal): updated comment * feat(attritionTableHistogramModal): removed unneeded file * feat(attritionTableHistogramModal): added variable rowIsOutcome * feat(attritionTableHistogramModal): ran linter and fixed spelling mistake in variable name * feat(attritionTableHistogramModal): added default values for AttritionTableRow modalInfo obj and func, added code to try to force re-draws of viz * feat(attritionTableHistogramModal): Ran linter, removed unneeded props from first row AttritionTableRow * feat(attritionTableHistogramModal): Removed duplicate modal and hoisted existing modal to be a child of AttritionTableWrapper to try to resolve issue with outcome diagram not re-drawing * feat(attritionTableHistogramModal): updated conditional for determining rowIsOutcome to use rowType string * feat(attritionTableHistogramModal): ran linter * feat(attritionTableHistogramModal): Updated ID ref used by Euler diagram in D3 call to be dynamic to avoid unexpected re-rendering --------- Co-authored-by: Shawn O'Connor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one: PPS-1564 PPS-1567 PPS-1585
Dependency updates