Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: unit tests for CohortsOverlapDiagram #1238

Merged

Conversation

pieterlukasse
Copy link
Contributor

@pieterlukasse pieterlukasse commented Feb 20, 2023

Jira Ticket: VADC-290

New Features

  • unit tests for CohortsOverlapDiagram, including mocking of web-services

@pieterlukasse pieterlukasse changed the base branch from master to feat/vadc_sprint04 February 21, 2023 14:47
Copy link
Contributor

@jarvisraymond-uchicago jarvisraymond-uchicago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nice job figuring out the SVG rendering issue. I confirmed that after pulling local test functions as expected.

@pieterlukasse pieterlukasse merged commit 2eff1d5 into feat/vadc_sprint04 Feb 21, 2023
@pieterlukasse pieterlukasse deleted the feat/jest_tests_for_overlap_diagram branch February 21, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants