Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/tests for Euler diagram #1198

Closed
wants to merge 5 commits into from

Conversation

pieterlukasse
Copy link
Contributor

@pieterlukasse pieterlukasse commented Jan 11, 2023

Jira Ticket: VADC-290

New Features

  • new tests for Euler diagram component

* feat(gwasUnifiedFlowStyleSidebars): Initial commit

* feat(gwasUnifiedFlowStyleSidebars): ran eslint new

* feat(gwasUnifiedFlowStyleSidebars): ran stylelint, removed unneeded CSS rules, removed unneeded prop

* feat(gwasUnifiedFlowStyleSidebars): added rule back so buttons align

* feat(gwasUnifiedFlowStyleSidebars): made covariates prop for SelectOutcome not required

* feat(gwasUnifiedFlowStyleSidebars): ran eslint new

* feat(gwasUnifiedFlowStyleSidebars): changed prop type for covariates to array
 includes:
   - working JEST test with mocks
   - fix to use correct cohortMiddlewareApi.js and to stop initializing WTS since this is not necessary anymore and is done globally. This was removed here so there would be less things to mock/worry about as well
@pieterlukasse pieterlukasse changed the base branch from master to feat/vadc_sprint01 January 11, 2023 20:43
Base automatically changed from feat/vadc_sprint01 to master January 25, 2023 05:30
@pieterlukasse
Copy link
Contributor Author

replaced by #1238

@ocshawn ocshawn deleted the feat/tests_for_euler_diagram branch August 14, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants