Fix and add test cases for Canvas Integration #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add docker definitions for new containers running test cases - Revise the sample testing data in ipeer_samples_data.sql to include features added by Canvas integration - Revising existing test cases - Adding new test cases canvas_integration.test.php for Canvas integration - Set the Selenium browser as Chrome in docker-compose.yml. The current Selenium-Firefox container has problem with some of the test cases (e.g. simulating mouse actions to control a slider) - Update readme.md on how to setup Selenium docker container and corresponding iPeer containers for runing integration tests
xcompass
reviewed
Dec 13, 2017
| @@ -192,8 +193,8 @@ function($session) { | |||
| $this->assertEqual($title, 'MECH 328 - Mechanical Engineering Design Project > Simple Evaluation > Results'); | |||
|
|
|||
| //auto-release results message | |||
| $msg = $this->session->elementsWithWait(PHPWebDriver_WebDriverBy::ID, 'autoRelease_msg'); | |||
| $this->assertTrue(!empty($msg)); | |||
| // $msg = $this->session->elementsWithWait(PHPWebDriver_WebDriverBy::ID, 'autoRelease_msg'); | |||
There was a problem hiding this comment.
Any reason these tests are commented out?
There was a problem hiding this comment.
There is no element autoRelease_msg displyed on screen. Seems the element only appears in test cases and CSS. Hence they are commented out.
localhost:~/work/iPeer> grep -lr "autoRelease_msg" *
app/tests/cases/system/student_mixeval.test.php
app/tests/cases/system/student_simple.test.php
app/tests/cases/system/student_rubric.test.php
app/webroot/css/ipeer.css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #547