Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect timezone adjustment #494

Closed
mwytang opened this issue Dec 2, 2014 · 0 comments
Closed

incorrect timezone adjustment #494

mwytang opened this issue Dec 2, 2014 · 0 comments
Milestone

Comments

@mwytang
Copy link
Contributor

mwytang commented Dec 2, 2014

Currently during certain time of the year, the "Due In" column on the student's homepage is off by one hour.

eg. evaluation is due at 12am and right now is 9pm it will say 2 hours left instead of 3 hours left.

Right now the implementation is:

  • If current time is in daylight savings - no adjustments
  • If current time is NOT in daylight savings - add one hour

I think the correct implementation should also depend on the due date of the event

  • If current time is in daylight savings and the due date is NOT - subtract one hour from current time
  • If current time is NOT in daylight savings and the due date is - add one hour to the current time
  • If current time and due date are both in daylight savings OR both NOT - No adjustments
@xcompass xcompass modified the milestone: V3.1.8 Dec 12, 2015
xcompass added a commit that referenced this issue Dec 13, 2015
Use PHP DateTime for due_in calculation.
xcompass added a commit that referenced this issue Dec 14, 2015
Use PHP DateTime for due_in calculation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants