Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

medium.com: nuisance #19120

Closed
9 tasks done
3xploiton3 opened this issue Jul 22, 2023 · 6 comments
Closed
9 tasks done

medium.com: nuisance #19120

3xploiton3 opened this issue Jul 22, 2023 · 6 comments
Labels

Comments

@3xploiton3
Copy link

Prerequisites

  • I read and understand the policy about what is a valid filter issue.
  • I verified that this issue is not a duplicate. (Use this button to find out.)
  • I forced an update of my filter lists. (Click the "Purge all caches" button while holding the 'Shift' key, then click the "Update now" button.)
  • I did not remove any of the default filter lists, or I have verified that the issue was not caused by removing any of the default lists.
  • I did not enable external filter lists, or I have verified that the issue still occurs without enabling external filter lists.
  • I do not have custom filters/rules, or I have verified that the issue still occurs without custom filters/rules.
  • I am not using uBlock Origin (uBO) along with other content blocker extensions.
  • I have verified that the web browser's built-in blocker or DNS blocking (standalone or through a VPN) is not causing the issue.
  • I did not answer truthfully to ALL the above checkpoints.

URL address of the web page

https://medium.com/teamresellerclub/how-to-protect-your-vps-hosted-website-from-ddos-threats-119e121b430b

Category

nuisance

Description

image

Other extensions used

no

Screenshot(s)

Screenshot(s)

Configuration

uBlock Origin 1.50.0:
 since: 35d.50m
Chromium: 114
filterset (summary):
 network: 128948
 cosmetic: 142368
 scriptlet: 26458
 html: 0
listset (total-discarded, last-updated):
 added:
  https://adblockid.pages.dev/adblockid.adfl.txt: 9882-4, 22h.35m
  https://adblockid.pages.dev/adblockid_plus.adfl.txt: 524-4, 1d.22h.38m
  DEU-0: 6962-0, 22h.37m
  IDN-0: 9560-368, 1d.22h.39m
  RUS-0: 39622-50, 1d.22h.39m
  ara-0: 2321-6, 22h.36m
  easylist-annoyances: 3895-47, 1d.22h.38m
  easylist-chat: 130-0, 1d.22h.38m
  easylist-notifications: 2633-102, 1d.22h.38m
  fanboy-cookiemonster: 47750-230, 1d.22h.38m
  fanboy-social: 16106-10, 1d.22h.38m
  ublock-annoyances: 5293-80, 1d.22h.38m
 default:
  user-filters: 8-0, never
  easylist: 68304-62, 1d.22h.38m
  easyprivacy: 33339-244, 1d.22h.38m
  plowe-0: 3723-1075, 1d.22h.38m
  ublock-badware: 7560-144, 1d.22h.38m
  ublock-filters: 33904-354, 1d.22h.38m
  ublock-privacy: 429-7, 1d.22h.38m
  ublock-quick-fixes: 321-25, 25m
  ublock-unbreak: 2085-41, 1d.22h.38m
  urlhaus-1: 6440-0, 22h.34m
filterset (user): [array of 8 redacted]
trustedset:
 added: [array of 13 redacted]
switchRuleset:
 added: [array of 4 redacted]
userSettings:
 advancedUserEnabled: true
 cloudStorageEnabled: true
 suspendUntilListsAreLoaded: true
hiddenSettings:
 autoUpdatePeriod: 1
supportStats:
 allReadyAfter: 2111 ms (selfie)
 maxAssetCacheWait: 564 ms
popupPanel:
 blocked: 12
 network:
  medium.com: 6
  cloudflareinsights.com: 1
  datadoghq.com: 1
  google.com: 2
  googletagmanager.com: 1
  youtube.com: 1
@stephenhawk8054
Copy link
Member

stephenhawk8054 commented Jul 22, 2023

@gorhill This banner can be hidden by setting local storage item to "2023-07-22T08:10:04.697Z". Could there be any ways to convert $currentDate$ to this format?

This filter works for me

medium.com##+js(trusted-set-local-storage-item, 'lo-non-moc-membership-upsell|dismissed-at', '"2023-07-22T08:10:04.697Z"')

but it would need constant updates to the date


Normal cosmetic filters can be used but they cause quite big flicker (due to medium.com random classes)

@gorhill
Copy link
Member

gorhill commented Jul 22, 2023

I will add $currentISODate$.

gorhill added a commit to gorhill/uBlock that referenced this issue Jul 22, 2023
Related feedback:
- uBlockOrigin/uAssets#19120 (comment)

Additionally, improve logging in `m3u-prune` scriptlet.
@stephenhawk8054
Copy link
Member

stephenhawk8054 commented Jul 23, 2023

@gorhill Looks like the site needs to put the date inside "". Is it possible to put date values ($now$, $currentDate$, $currentISODate$) inside quotations?

If it complicates the code, then I think it's fine to keep as-is.

@gorhill
Copy link
Member

gorhill commented Jul 23, 2023

Is it possible to put date values ($now$, $currentDate$, $currentISODate$) inside quotations?

Doing this potentially breaks other cases using these variables, i.e. other sites may not expect quotes. The reason this site might need quotes is because it's serializing through JSON, so a better solution would be to maybe offer a serialization type using optional extra parameters:

medium.com##+js(trusted-set-local-storage-item, 'lo-non-moc-membership-upsell|dismissed-at', $currentISODate$, serialize, json)

cc @ameshkov to have his toughts on this

@stephenhawk8054
Copy link
Member

I see. That's indeed a better approach.

@stephenhawk8054
Copy link
Member

I didn't realize the same issue was declined already: #18854 and it's indeed self-promotion so I'm gonna remove the filters

stephenhawk8054 added a commit that referenced this issue Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants