Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#32 Initial GHA rules. #33

Merged
merged 2 commits into from
Oct 25, 2023
Merged

#32 Initial GHA rules. #33

merged 2 commits into from
Oct 25, 2023

Conversation

adiroiban
Copy link
Member

@adiroiban adiroiban commented Oct 25, 2023

Fixes #32

Try to update the CI infa for this repo. Just basic stuff.

Without tox.


GitHub Branch proection setup via https://github.com/twisted/constantly/settings/branch_protection_rules/1044842


PyPi publishing setup via https://pypi.org/manage/project/constantly/settings/publishing/

We will only test it with the new release. But it's the same code from towncrier.


Read The Docs update will be done in a separate PR, as I don't have admin permission for RTD.

@adiroiban adiroiban force-pushed the 32-gha-ci branch 5 times, most recently from 293997a to bbf51e5 Compare October 25, 2023 16:18
@adiroiban
Copy link
Member Author

I think that this is ready for review.

Just basic stuff.

We can do more in separate PRs.

needs-review

Copy link
Member

@glyph glyph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate that programming in the 2020s is just copy-pasting yaml from one file to another , but it it what it is

@glyph glyph merged commit 6981a9d into master Oct 25, 2023
@glyph glyph deleted the 32-gha-ci branch October 25, 2023 18:25
@adiroiban
Copy link
Member Author

In theory, you can create an action and reuse the yaml .

It's not that bad :)

The fact that we have GitHub Action available for free and don't have to manage your custom buildbot lab, is a huge improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup CI
2 participants