Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpgme: migrate to [email protected] #150388

Merged
merged 6 commits into from
Oct 30, 2023

Conversation

branchvincent
Copy link
Member

gpgme: migrate to [email protected]

@chenrui333
Copy link
Member

regression test failure with alot

Expected #<Pathname:/private/tmp/alot-test-20231009-87382-bom0w8/out.log> to be exist?.

@chenrui333 chenrui333 added the test failure CI fails while running the test-do block label Oct 10, 2023
@cho-m
Copy link
Member

cho-m commented Oct 10, 2023

Need to migrate dependents that use Python bindings like alot (which also requires notmuch).

Which also means gpgme and other formulae will need revision bump.

@chenrui333 chenrui333 added the python Python use is a significant feature of the PR or issue label Oct 10, 2023
@chenrui333
Copy link
Member

chenrui333 commented Oct 25, 2023

constantly need some build change

  ==> python3.12 -m pip --python=/opt/homebrew/Cellar/alot/0.10_3/libexec/bin/python install --verbose --no-deps --no-binary=:all: --ignore-installed --no-compile /private/tmp/alot--constantly-20231015-45973-vhnx3y/constantly-15.1.0
  Using pip 23.2.1 from /opt/homebrew/lib/python3.12/site-packages/pip (python 3.12)
  Processing /private/tmp/alot--constantly-20231015-45973-vhnx3y/constantly-15.1.0
    Preparing metadata (setup.py): started
    Running command python setup.py egg_info
    /private/tmp/alot--constantly-20231015-45973-vhnx3y/constantly-15.1.0/versioneer.py:467: SyntaxWarning: invalid escape sequence '\s'
      LONG_VERSION_PY['git'] = '''
    Traceback (most recent call last):
      File "<string>", line 2, in <module>
      File "<pip-setuptools-caller>", line 34, in <module>
      File "/private/tmp/alot--constantly-20231015-45973-vhnx3y/constantly-15.1.0/setup.py", line 41, in <module>
        version=versioneer.get_version(),
                ^^^^^^^^^^^^^^^^^^^^^^^^
      File "/private/tmp/alot--constantly-20231015-45973-vhnx3y/constantly-15.1.0/versioneer.py", line 1405, in get_version
        return get_versions()["version"]
               ^^^^^^^^^^^^^^
      File "/private/tmp/alot--constantly-20231015-45973-vhnx3y/constantly-15.1.0/versioneer.py", line 1339, in get_versions
        cfg = get_config_from_root(root)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/private/tmp/alot--constantly-20231015-45973-vhnx3y/constantly-15.1.0/versioneer.py", line 399, in get_config_from_root
        parser = configparser.SafeConfigParser()
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    AttributeError: module 'configparser' has no attribute 'SafeConfigParser'. Did you mean: 'RawConfigParser'?

@chenrui333
Copy link
Member

Just FYI, there is a new release with gpgme, so I created a PR separately, #152346

@cho-m
Copy link
Member

cho-m commented Oct 25, 2023

constantly need some build change

There is an open PR now twisted/constantly#31. Bit worried that upstream's last commit was 2018 and last release was 2015 but constantly is owned/used by twisted, which is actively maintained.

@chenrui333
Copy link
Member

chenrui333 commented Oct 25, 2023

constantly need some build change

There is an open PR now twisted/constantly#31. Bit worried that upstream's last commit was 2018 and last release was 2015 but constantly is owned/used by twisted, which is actively maintained.

good point, gonna raise an issue in twisted/twisted for some awareness.

@chenrui333
Copy link
Member

@alex
Copy link
Contributor

alex commented Oct 28, 2023

constantly now has a released which should work on python 3.12

@branchvincent branchvincent added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed test failure CI fails while running the test-do block labels Oct 29, 2023
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Oct 29, 2023
@branchvincent branchvincent added the ready to merge PR can be merged once CI is green label Oct 30, 2023
Comment on lines 50 to 53
resource "constantly" do
url "https://files.pythonhosted.org/packages/95/f1/207a0a478c4bb34b1b49d5915e2db574cadc415c9ac3a7ef17e29b2e8951/constantly-15.1.0.tar.gz"
sha256 "586372eb92059873e29eba4f9dec8381541b4d3834660707faf8ba59146dfc35"
url "https://files.pythonhosted.org/packages/4d/6f/cb2a94494ff74aa9528a36c5b1422756330a75a8367bf20bd63171fc324d/constantly-23.10.4.tar.gz"
sha256 "aa92b70a33e2ac0bb33cd745eb61776594dc48764b06c35e0efd050b7f1c7cbd"
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 30, 2023
@BrewTestBot BrewTestBot enabled auto-merge October 30, 2023 15:59
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 30, 2023
Merged via the queue into Homebrew:master with commit 7fe479c Oct 30, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age python Python use is a significant feature of the PR or issue python-3.12-migration ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants