Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Drop asyncio from requirements #709

Merged
merged 2 commits into from
Apr 14, 2023
Merged

chore: Drop asyncio from requirements #709

merged 2 commits into from
Apr 14, 2023

Conversation

setu4993
Copy link
Contributor

Fixes #708

asyncio is relevant (and distributed) only for Python 3.3 per PyPI. Including it after that results in a no-op but fails pip check.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

@kridai kridai merged commit ea3b70e into twilio:main Apr 14, 2023
@setu4993 setu4993 deleted the chore/drop-asyncio branch April 15, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kridai kridai kridai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extra dependency asyncio included
2 participants
@setu4993 @kridai