Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra dependency asyncio included #708

Closed
setu4993 opened this issue Apr 10, 2023 · 2 comments · Fixed by #709
Closed

Extra dependency asyncio included #708

setu4993 opened this issue Apr 10, 2023 · 2 comments · Fixed by #709
Labels
status: code review request requesting a community code review or review from Twilio type: bug bug in the library

Comments

@setu4993
Copy link
Contributor

asyncio is a dependency only for upto Python 3.4. Since the versions of Python supported are 3.7+, it doesn't seem to be required, but is included.

This is causing issues with running pip check in conda-forge/twilio-feedstock#94, which I help maintain.

Technical details:

  • twilio-python version: 8.0.0
  • python version: 3.7+
setu4993 added a commit to regro-cf-autotick-bot/twilio-feedstock that referenced this issue Apr 10, 2023
@setu4993
Comment out pip check
5c5f3ae 
`asyncio` isn't distributed for Python 3.7+, but for some reason included in the dependencies for `twilio` 8.0.0. This is causing issues.

twilio/twilio-python#708
@setu4993 setu4993 mentioned this issue Apr 10, 2023
Merged
8 tasks
setu4993 added a commit to conda-forge/twilio-feedstock that referenced this issue Apr 10, 2023
@regro-cf-autotick-bot @setu4993
[bot-automerge] twilio v8.0.0 (#94)
f613bfc 
* updated v8.0.0

* Drop py36

* Add aiohttp, aiohttp-retry

* Add `asyncio`

* Drop whitespace

* Drop `asyncio`

* Comment out `pip check`

`asyncio` isn't distributed for Python 3.7+, but for some reason included in the dependencies for `twilio` 8.0.0. This is causing issues.

twilio/twilio-python#708

* Add comment

---------

Co-authored-by: Setu Shah <[email protected]>
@AsabuHere AsabuHere added type: bug bug in the library status: code review request requesting a community code review or review from Twilio labels Apr 11, 2023
@nelsonlazar
Copy link

asyncio has broken our Serverless Lambda function(Python v3.8):

[ERROR] SyntaxError: invalid syntax (base_events.py, line 296)
...
File "/var/task/django/utils/deprecation.py", line 1, in
import asyncio
File "/var/task/asyncio/init.py", line 21, in
from .base_events import *

As a workaround fixed using version lock with previous version of Twilio

@kridai
Copy link
Contributor

kridai commented Apr 14, 2023

Thanks for the PR. The changes have been merged, and would reflect in the next twilio-python release.

This was referenced Apr 21, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio type: bug bug in the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Drop asyncio from requirements setu4993/twilio-python
4 participants
@setu4993 @kridai @nelsonlazar @AsabuHere