fix(runtime-handler): using set-cookie now sets cookie header #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the implementation of the Functions runtime-handler, the Response object sets the Set-Cookie header to [] if there are no cookies set. If you then set a header with the key 'set-cookie' (or any other capitalisation) it will be eventually overridden by the empty array under Set-Cookie (since it is also added to the headers last). To fix this all cookies are set under the key 'Set-Cookie'.
dkundel
approved these changes
Jul 27, 2021
dkundel
added a commit
that referenced
this pull request
Oct 14, 2021
* feat(runtime-handler): handle incoming headers and cookies (#293) * feat(handler): update header and cookie support for Response (#296) * feat(runtime-types): add cookie/header support for types (#297) * build: adjust dependency imports for successful build (#314) * chore(runtime-handler): add artifical rc-version bump * chore(release): publish %s - [email protected] - @twilio-labs/[email protected] - @twilio/[email protected] - @twilio-labs/[email protected] - [email protected] * fix(runtime-handler): using set-cookie now sets cookie header (#332) * chore(release): publish %s - @twilio/[email protected] * chore(release): publish %s - @twilio/[email protected] * Update package.json * Update package.json Co-authored-by: Phil Nash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the implementation of the Functions runtime-handler, the Response object
sets the Set-Cookie header to [] if there are no cookies set. If you then set a
header with the key 'set-cookie' (or any other capitalisation) it will be eventually
overridden by the empty array under Set-Cookie (since it is also added to the headers last).
To fix this all cookies are set under the key 'Set-Cookie'.
Contributing to Twilio