Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(handler): update header and cookie support for Response #296

Merged
merged 2 commits into from
Jul 6, 2021
Merged

feat(handler): update header and cookie support for Response #296

merged 2 commits into from
Jul 6, 2021

Conversation

philnash
Copy link
Contributor

@philnash philnash commented Jul 2, 2021

  • Ensures 'Set-Cookie' is present with at least an empty array
  • Handles multi value headers in appendHeader
  • Adds setCookie and removeCookie functions

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@philnash philnash changed the title feat(handler): update header and cookie support feat(handler): update header and cookie support for Response Jul 2, 2021
@philnash philnash requested a review from dkundel July 2, 2021 06:16
@dkundel dkundel mentioned this pull request Jul 2, 2021
Merged
1 task
@dkundel dkundel merged commit e9ef02e into features/handler-1.2.0 Jul 6, 2021
@dkundel dkundel deleted the features/handler-set-cookie-support branch July 6, 2021 22:07
dkundel added a commit that referenced this pull request Oct 14, 2021
@dkundel @philnash
feat: add support for request headers & cookies (#373)
989307d 
* feat(runtime-handler): handle incoming headers and cookies (#293)

* feat(handler): update header and cookie support for Response (#296)

* feat(runtime-types): add cookie/header support for types (#297)

* build: adjust dependency imports for successful build (#314)

* chore(runtime-handler): add artifical rc-version bump

* chore(release): publish %s

 - [email protected]
 - @twilio-labs/[email protected]
 - @twilio/[email protected]
 - @twilio-labs/[email protected]
 - [email protected]

* fix(runtime-handler): using set-cookie now sets cookie header (#332)

* chore(release): publish %s

 - @twilio/[email protected]

* chore(release): publish %s

 - @twilio/[email protected]

* Update package.json

* Update package.json

Co-authored-by: Phil Nash <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkundel dkundel dkundel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philnash @dkundel