generated from obsidianmd/obsidian-sample-plugin
-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dart support #174
Merged
+60
−2
Merged
Add dart support #174
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
595d208
Add dart support
andremeireles 51a08fa
Fix typo in readme file in dart summary.
andremeireles f95dd0c
Add requirements note in readme file.
andremeireles 8613bad
Merge branch 'develop' into develop
andremeireles 863b011
format dart snippet
andremeireles e9426b2
Merge branch 'develop' into andremeireles_develop
twibiral File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
import { Setting } from "obsidian"; | ||
import { SettingsTab } from "../SettingsTab"; | ||
|
||
export default (tab: SettingsTab, containerEl: HTMLElement) => { | ||
containerEl.createEl('h3', { text: 'Dart Settings' }); | ||
new Setting(containerEl) | ||
.setName('dart path') | ||
.addText(text => text | ||
.setValue(tab.plugin.settings.dartPath) | ||
.onChange(async (value) => { | ||
const sanitized = tab.sanitizePath(value); | ||
tab.plugin.settings.dartPath = sanitized; | ||
console.log('dart path set to: ' + sanitized); | ||
await tab.plugin.saveSettings(); | ||
})); | ||
new Setting(containerEl) | ||
.setName('Dart arguments') | ||
.addText(text => text | ||
.setValue(tab.plugin.settings.dartArgs) | ||
.onChange(async (value) => { | ||
tab.plugin.settings.dartArgs = value; | ||
console.log('Dart args set to: ' + value); | ||
await tab.plugin.saveSettings(); | ||
})); | ||
tab.makeInjectSetting(containerEl, "dart"); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, @twibiral is the one to update the changelog when it is time for the next release. I'm not sure what the correct procedure is or what he would prefer re: this commit, but I wanted to make sure you were aware of that :) sorry!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chlohal is right, I would prefer if you could remove this @andremeireles. The version number is finalized before a new version is released and added to the CHANGELOG by a script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, great.
I think it is now ready to be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!