-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dart support #174
Add dart support #174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 Your code looks great! One note regarding the changelog, but everything else looks nice. Thank you for your contribution!
CHANGELOG.md
Outdated
@@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file. | |||
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
|
|||
|
|||
## [1.5.0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, @twibiral is the one to update the changelog when it is time for the next release. I'm not sure what the correct procedure is or what he would prefer re: this commit, but I wanted to make sure you were aware of that :) sorry!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chlohal is right, I would prefer if you could remove this @andremeireles. The version number is finalized before a new version is released and added to the CHANGELOG by a script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, great.
I think it is now ready to be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for the contribution @andremeireles, I really appreciate it! Before merging, please do the change commented above and resolve the merge conflicts (this should be pretty straightforward) |
Tab is 2 spaces.
CHANGELOG.md
Outdated
@@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file. | |||
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
|
|||
|
|||
## [1.5.0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Omg I'm excited for this, just discovered this plugin and use Dart professionally, nice job @andremeireles !! |
I don’t know what to say. Thank you. |
@twibiral is there anything else needed for this to go through? No rush of course, just curious ❤️ |
# Conflicts: # README.md # src/main.ts
It will be released soon :) |
This adds support for the dart language, based on the lua implementation.