Always hide running indicator #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used some CSS changes to fix #150. This uses
opacityto hide the running indicator: even though it's below the<pre>block, this is more robust against themes' changes.I'm not sure whether or not this is the same fix that @ZackYJz used. I didn't use their CSS, but I'm definitely willing to give co-author credit for the idea if it is the same. (zackyjz, please feel free to reply to this PR regarding that! :) )
I also fixed an issue with the Minimal Theme where fold padding would move the codeblock sideways, but not the indicator.