Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading status does not disappear after running #150

Closed
ZackYJz opened this issue Oct 22, 2022 · 8 comments · Fixed by #159
Closed

Loading status does not disappear after running #150

ZackYJz opened this issue Oct 22, 2022 · 8 comments · Fixed by #159
Labels
bug Something isn't working

Comments

@ZackYJz
Copy link

ZackYJz commented Oct 22, 2022

After running, there is a loading circle in the upper left corner, which cannot be clicked and will not disappear. I'm not sure what caused it.
image

@chlohal
Copy link
Collaborator

chlohal commented Oct 22, 2022

Do you have any other plugins or themes installed? One of them could be conflicting with the loading indicator. If you would feel comfortable sending a list, I can look into it and code a fix :)

@ZackYJz
Copy link
Author

ZackYJz commented Oct 22, 2022

Do you have any other plugins or themes installed? One of them could be conflicting with the loading indicator. If you would feel comfortable sending a list, I can look into it and code a fix :)

Thank you for reply. I tried, it turned out to be the theme "Blue Topaz"

@ZackYJz
Copy link
Author

ZackYJz commented Oct 24, 2022

Do you have any other plugins or themes installed? One of them could be conflicting with the loading indicator. If you would feel comfortable sending a list, I can look into it and code a fix :)

I solved this conflict by writing a CSS snippet. Another problem:
Even if it's running normally, an "Error" will also pop up. Is there a problem with the logic in the following pictrue?
image

@ZackYJz
Copy link
Author

ZackYJz commented Oct 24, 2022

Solved by FOLLOW CSS

.load-state-indicator {
	position: absolute;
	top: 0.5em;
	left: -2em;
	widtH: 2em;
	height: 2em;
    opacity: 0.6;
	background: var(--background-primary-alt);
	border-top-left-radius: 4px;
	border-bottom-left-radius: 4px;
	color: var(--tx1);
	transform: translateX(0);
	transition: transform 0.25s, opacity 0.25s;
	opacity: 0;
	z-index: 2;
}

.load-state-indicator svg {
	width: 1.5em;
	height: 1.5em;
	margin: 0.25em;
}

.has-run-code-button {
	overflow: hidden;
	position: relative;
}

.has-run-code-button pre {
	margin: 0;
	z-index: 1;
}

.load-state-indicator.visible {
	transform: translateX(2em);
	opacity: 0.6;
}

.load-state-indicator::before {
	content: "";
	box-shadow: -1em 0 1em -0.75em inset var(--background-modifier-box-shadow);
	position: absolute;
	display: block;
	width: 100%;
	height: 100%;
	transform: translateX(0);
	opacity: 1;
	transition: transform 0.25s, opacity 0.25s;
}

.load-state-indicator.visible::before {
	transform: translateX(-2em);
	opacity: 0;
}

@chlohal
Copy link
Collaborator

chlohal commented Oct 24, 2022

Another problem: Even if it's running normally, an "Error" will also pop up. Is there a problem with the logic in the following pictrue? image

Yep! Thanks-- this error is fixed on the develop branch (see #144 ), so it should disappear in the next release. Thank you :)

@chlohal
Copy link
Collaborator

chlohal commented Oct 24, 2022

Thank you for the CSS! If you don't mind my asking, do you know how it works/what the diff is? If so, then you could open a PR to make sure it works with all themes: the file src/styles.css has all of what you'll need :)

@twibiral twibiral added the bug Something isn't working label Oct 26, 2022
@mayurankv
Copy link
Contributor

Also have this issue with minimal theme and no other codeblock appearance affecting plugins I know of (though quite a few in general). Will try out the css and see if that helps

@chlohal
Copy link
Collaborator

chlohal commented Oct 28, 2022

Hmm, ok. I'm going to try a few things & see if we can make it play well with all themes. Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants