Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Locating Path Settings Instruction #149

Merged
merged 6 commits into from
Jan 16, 2023
Merged

Added Locating Path Settings Instruction #149

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
726d629
Added Locating Path Settings Instruction
Oct 21, 2022
efa289c
Update README.md
Oct 22, 2022
caeec5f
Update README.md
Oct 22, 2022
c3a0705
Update README.md
Oct 22, 2022
954ccf0
Update README.md
Oct 22, 2022
46bbccc
docu: store the images in the repository
twibiral Jan 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,20 @@ In your vault go to Settings > Community plugins > Browse and search for "Execut
or

Follow [this link](https://obsidian.md/plugins?search=execute%20code#) and click "Open in Obsidian".

## Locating Path Settings ( ex. JavaScript | Node )

To avoid or resolve errors from an incorrect path.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed something else: since you have indentation before each line, your changes are all inside a code block. Was that intentional? sorry

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks -- first pull request. Now it looks right. :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha :) no worries!!! PRs are always welcome, and thank you very much for working with us to make sure it's the best it can be!!


1. In your terminal, type 'where node'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where works on Windows, but not Linux. Does it work on Mac? Should we include per-OS instructions?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where works on mac as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhh --- good. I am on a mac. I will update. Anybody know linux command to find path?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on Linux, it is which :)


![CleanShot 2022-10-21 at 19 03 49@2x](https://user-images.githubusercontent.com/11916140/197303215-07ff9460-201d-4c0a-95a3-3b1263713a35.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure which one is preferred between the markdown ![]() syntax or <img> (ln 468), but I don't think they should be mixed for style reasons. I'm open to any opinions/discussion you have re: this! :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think that descriptive alt text might help w/ images

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah -- sorry. I was just pasting the images in. I can update that!

Copy link
Collaborator

@milan338 milan338 Oct 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it matters, ![]() is a lot cleaner, using an <img> tag is only really necessary for manually setting image dimensions (some images take up a lot of space in the readme, it might be good to reduce their size).


2. Copy path from terminal ( ex. /opt/homebrew/bin/node )

3. Paste in path under settings ( ex. Node path )

<img width="807" alt="CleanShot 2022-10-21 at 18 59 48@2x" src="https://user-images.githubusercontent.com/11916140/197303057-a9f05c03-5bfc-44d7-b583-9028a3279eaf.png">

## Warning

Expand Down