Added Locating Path Settings Instruction #149
Conversation
Put in instructions for finding the path for language specifics. Example is for node but should work with others. Hope that is helpful. Steven
README.md
Outdated
|
|
||
| 1. In your terminal, type 'where node' | ||
|
|
||
|  |
There was a problem hiding this comment.
I'm not sure which one is preferred between the markdown ![]() syntax or <img> (ln 468), but I don't think they should be mixed for style reasons. I'm open to any opinions/discussion you have re: this! :)
There was a problem hiding this comment.
i think that descriptive alt text might help w/ images
There was a problem hiding this comment.
Yeah -- sorry. I was just pasting the images in. I can update that!
There was a problem hiding this comment.
I don't think it matters, ![]() is a lot cleaner, using an <img> tag is only really necessary for manually setting image dimensions (some images take up a lot of space in the readme, it might be good to reduce their size).
README.md
Outdated
|
|
||
| To avoid or resolve errors from an incorrect path. | ||
|
|
||
| 1. In your terminal, type 'where node' |
There was a problem hiding this comment.
where works on Windows, but not Linux. Does it work on Mac? Should we include per-OS instructions?
There was a problem hiding this comment.
where works on mac as well
There was a problem hiding this comment.
ahhh --- good. I am on a mac. I will update. Anybody know linux command to find path?
|
thanks for your pr!!!! :D |
Updated image styling
README.md
Outdated
|
|
||
| ## Locating Path Settings ( ex. JavaScript | Node ) | ||
|
|
||
| To avoid or resolve errors from an incorrect path. |
There was a problem hiding this comment.
I just noticed something else: since you have indentation before each line, your changes are all inside a code block. Was that intentional? sorry
There was a problem hiding this comment.
Thanks -- first pull request. Now it looks right. :)
There was a problem hiding this comment.
gotcha :) no worries!!! PRs are always welcome, and thank you very much for working with us to make sure it's the best it can be!!
|
One more thing that I just noticed: the images appear to be the same
I don't think that's on purpose, since your first commit had this image for the second one. I'm sorry I didn't notice that!! (when in the code block, they weren't rendering) Other than that, LGTM! |
fixed image
awesome -- anything else I need to do or just wait for it to be approved? :) |
|
Nope! It's all good; just wait for @twibiral to see it :) he might have more notes, but if he does, usually they're relatively easy to complete. Thank you again for your PR! |
|
Hi, thank you for adding this explanation to the readme, and sorry for the late response. Where are the images stored? I would prefer to keep a copy of them in the images folder of this repo so they don't suddenly vanish sometime in the future. |
|
I saved the images used in the repo and changed the links accordingly. It will be released soon. |
Put in instructions for finding the path for language specifics. Example is for node but should work with others. Hope that is helpful.
Steven