Only pass -no-pie for binary targets #1424
Conversation
When using GHC 8.10, passing `-no-pie` to the linker when building libraries leads to obscure linker errors. Since PIE pertains to executables, it doesn't make much sense passing that flag when building libraries anyways. Removing it, both for `haskell_library` and `haskell_cabal_library` fixes GHC 8.10 support. We make sure to keep the flag for executables. This would otherwise negate the effect of #1388.
|
This PR does not change the compiler version used during testing. We still test with GHC 8.8.3 only, whereas the bug the PR is fixing only appears on GHC 8.10.*. @patrickt you may also want to confirm that this fixes the linker errors you saw when then moving Semantic to GHC 8.10. |
As per tweag/rules_haskell#1424, the linker errors associated with Actions CI should be fixed now.
|
Doesn’t seem to work on our end just yet: Full backscroll here: https://github.com/github/semantic/pull/627/checks?check_run_id=1123152233 |
|
@patrickt I see that error with GHC 8.8 but not 8.10. Are you sure you are using 8.10? For 8.8, I'll push a workaround to the workaround. The logic is getting really complex, all to paper over a lack of proper solution to https://gitlab.haskell.org/ghc/ghc/-/issues/15319. I think we should tackle that next. |
mboes
force-pushed
the
no-library-no-pie
branch
from
09e9860 to
d81268f
Compare
|
It seems to be working now!! You’re the best, @mboes! And indeed, linker errors are my least favorite part of programming. |
When using GHC 8.10, passing
-no-pieto the linker when buildinglibraries leads to obscure linker errors. Since PIE pertains to
executables, it doesn't make much sense passing that flag when
building libraries anyways. Removing it, both for
haskell_libraryand
haskell_cabal_libraryfixes GHC 8.10 support. We make sure tokeep the flag for executables. This would otherwise negate the effect
of #1388.
Fixes #1418