Fix linker errors on Ubuntu >= 18.04 with GHC bindist #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the suggestion from bazelbuild/bazel#6876 (comment)
Covers R_X86_64_32 relocation errors and incompatibility of `-r` and `-pie` on Ubuntu>=18.04.
aherrmann
commented
Jul 7, 2020
| @@ -112,9 +113,6 @@ def cc_interop_info(ctx): | |||
| cc_files = ctx.files._cc_toolchain + cc_wrapper.inputs.to_list() | |||
| cc_manifests = cc_wrapper.manifests | |||
|
|
|||
| # XXX Workaround https://github.com/bazelbuild/bazel/issues/6876. | |||
| linker_flags = [flag for flag in linker_flags if flag not in ["-shared"]] | |||
There was a problem hiding this comment.
While debugging #1349 I noticed that this could be simplified by following the suggestion from bazelbuild/bazel#6876 (comment).
This was referenced Jul 7, 2020
hanshoglund
approved these changes
Jul 9, 2020
hanshoglund
reviewed
Jul 9, 2020
|
We were seeing this on github/semantic#595, and I can confirm that this patch fixes our Linux builds. |
Addressing review comment #1388 (comment)
As pointed out in this GHC note that corresponds to GHC's behavior provided that the C compiler supports the |
mboes
added a commit
that referenced
this pull request
Sep 16, 2020
When using GHC 8.10, passing `-no-pie` to the linker when building libraries leads to obscure linker errors. Since PIE pertains to executables, it doesn't make much sense passing that flag when building libraries anyways. Removing it, both for `haskell_library` and `haskell_cabal_library` fixes GHC 8.10 support. We make sure to keep the flag for executables. This would otherwise negate the effect of #1388.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1349
On some more recent Linux distributions (e.g. Ubuntu 18.04)
gccdefaults to linking with-pie. At the same time GHC passes-rto the linker when joining object files. In order to avoid errors of the formwe need to pass
-no-pieto the linker. Additionally, GHC compiles themainfunction during linking with non-position independent code. Attempting to link this code with-piewill cause the following error:This was not caught on rules_haskell's bindist CI since it was still running on Ubuntu 16.04 which hadn't enabled
-pieby default, yet. I've upgraded the rules_haskell bindist CI image to Ubuntu 18.04. I've confirmed that this does not break the build on Ubuntu 16.04.