"Fix: This is a fix for Clicking anywhere generates JS warnings in Firefox if a dropdown menu is present Issue #7318

[shishirmk]

When jQuery receives an empty id selector like this $("#") , it throws an error in firefox. This error is visible only in the web console provided by firefox. I was not able to see it in firebug console. I have just added a if statement as a workaround for it.

Here is the diff

--- a/js/bootstrap-dropdown.js
+++ b/js/bootstrap-dropdown.js
@@ -118,7 +118,11 @@
       selector = selector && /#/.test(selector) && selector.replace(/.*(?=#[^\s]*$)/, '') //st
     }

-    $parent = selector && $(selector)
+    if (selector === "#"){
+      $parent = $("")
+    } else {
+      $parent = selector && $(selector)
+    }

 if (!$parent || !$parent.length) $parent = $this.parent()

This is my first pull request hope I have done it right

[mdo]

Closed per comment in #7318.

[shishirmk]

@mdo I checked with v2.3.2 the problem is not fixed. I checked the diff there isnt anything to take care of the problem. The "Empty string passed to getElementById()" messages do still come. They are not seen in firebug but they are seen FF's built in error console.

[mdo]

I see nothing in Firefox's (v21) built in console when clicking around the dropdowns at http://twitter.github.io/bootstrap/javascript.html#dropdowns. Can you confirm the steps to reproduce, and include a screenshot of the error happening?

[shishirmk]

Here is a screenshot of the error.

Steps:
I went to the link given by you. I am using FF 21 on Win 7.
I press Shift + Ctrl + I This opens the developer tools.
I click on Web Console Then i click on anywhere in the page which has bootstrap dropdowns.
This throws an error as shown in the picture.
1 error per drop down. So 8 new such errors per click in this page.

[shishirmk]

@mdo I have replied to your message. Forgot to tag you

[shishirmk]

@mdo reproduced the problem on OSX too

[shishirmk]

Its actually just a warning not an error.

[fat]

yeah this is non critical and doesn't warrant a patch release. it'll be addressed in 3.0.0

[fat]

also the proposed patch here isn't the road we'd want to take

[shishirmk]

sure that makes sense.

[kshipp]

Confirming this is still a bug in 3.0.3.