Empty string passed to getElementById() in dropdown.js

[devsnd]

I am Using Firefox 22.

Reproduce:

• Open http://getbootstrap.com/components/
• The error is visible in the console when clicking anywhere in the page but a dropdown menu.

I could track down the error to the clearMenus call, which in turn calls getParents where the error finally happens.

In getParents the selector variable is set to '#'. This character is stripped away inside jQuery.

[cvrebert]

Regression of #7318.

[zba]

Milestone: v3.0.1

can we expect that this will be also fixed in 2.x branch ?

[cvrebert]

@zba Negatory. v2.x.x is no longer actively developed or supported.

[bgaillard]

Hi, it seems that this bug appears in Bootstrap 2 and 3,

If you want to (temporarily, waiting for the bug to be fixed) hide the warnings in your FF console you can simply overwrite the getElementById Javascript function.

BE CAREFUL : as @devsnd mention it this trick is a little "hazardous" so apply it at your own risks !

    // Fix for the following bugs
    // - https://github.com/twbs/bootstrap/issues/10044
    // - https://github.com/twbs/bootstrap/issues/5566
    // - https://github.com/twbs/bootstrap/pull/7692
    // - https://github.com/twbs/bootstrap/issues/8423
    // - https://github.com/twbs/bootstrap/issues/7318
    // - https://github.com/twbs/bootstrap/issues/8423
    if(navigator.userAgent.toLowerCase().indexOf('firefox') > -1) {

        document._oldGetElementById = document.getElementById;
        document.getElementById = function(id) {

            if(id === undefined || id === null || id === '') {

                return undefined;

            }

            return document._oldGetElementById(id);
        };

    }

Hope this helps,

Baptiste

[ghost]

/ / - Https://github.com/twbs/bootstrap/pull/7692
/ / - Https://github.com/twbs/bootstrap/issues/8423
/ / - Https://github.com/twbs/bootstrap/issues/7318
/ / - Https://github.com/twbs/bootstrap/issues/8423várva a hibát kell rögzíteni), elrejti a figyelmeztetések a FF konzol-nem aktívan fejlesztett és támogatott.

[devsnd]

@bgaillard, this seems like a very bad idea; This will only cover the problem and possibly others as well! You can patch bs3 the same way it was done in bs2:
#7692

[bgaillard]

@devsnd, you are absolutly right, my trick is not elegant an a little "risky".

This trick perfectly works on one of our project and we do not want to upgrade our Twitter Bootstrap lib because we consider that the risk to break other peace of codes by upgrading Twitter Bootstrap is more important that applying this trick.

But you're right my proposition is far from perfect and I should have mention it in my comment. When I had time to do it I'll proprose a pull request like yours.

It seems to be very simple, perhaps just copying your modifications and applying them at line 112 here https://github.com/bgaillard/bootstrap/blob/master/js/dropdown.js ?

Thanks.