Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search with xs to md breakpoints #36307

Merged
merged 1 commit into from
May 9, 2022

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented May 8, 2022

On your browser in responsive mode with a width of 991px or under OR with your mobile phone:

  1. Go to https://deploy-preview-36307--twbs-bootstrap.netlify.app/docs/5.1/getting-started/introduction/
  2. Click on "..."
  3. Click on search input → search popup appears
  4. Search input in the popup now gains automatically the focus. Search is now possible.

Fixes #36306

@julien-deramond julien-deramond marked this pull request as ready for review May 8, 2022 16:59
@mdo
Copy link
Member

mdo commented May 8, 2022

Ayyy thank you! Works great now :).

@mdo mdo force-pushed the main-jd-fix-search-on-mobile branch from 5be4554 to 94d11de Compare May 9, 2022 03:01
@mdo mdo merged commit 4207544 into twbs:main May 9, 2022
@mdo
Copy link
Member

mdo commented May 9, 2022

/cc @GeoSot if you have additional ideas here for a follow up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossible to search on mobile with new DocSearch v3
2 participants