Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Search is not working on mobile #36822

Closed
3 tasks done
ThibaultVlacich opened this issue Jul 23, 2022 · 7 comments · Fixed by #36824
Closed
3 tasks done

[DOCS] Search is not working on mobile #36822

ThibaultVlacich opened this issue Jul 23, 2022 · 7 comments · Fixed by #36824

Comments

@ThibaultVlacich
Copy link

ThibaultVlacich commented Jul 23, 2022

Prerequisites

Describe the issue

It's impossible to use the search field of the new docs on mobile (Safari on iOS).

When I touch the search field, keyboard is not opening.

IMG_0910.MOV

Reduced test cases

N/A

What operating system(s) are you seeing the problem on?

iOS

What browser(s) are you seeing the problem on?

Safari

What version of Bootstrap are you using?

N/A

@mdo
Copy link
Member

mdo commented Jul 23, 2022

@GeoSot @julien-deramond I think we changed something here between beta and stable. Any ideas?

@julien-deramond
Copy link
Member

julien-deramond commented Jul 23, 2022

This regression comes from 713d714.
We had this issue before in #36307 so something is not compatible with what we did before.

@GeoSot
Copy link
Member

GeoSot commented Jul 23, 2022

FocusTrap blocks everything outside offcanvas :/

Choices:

  • find a way to open algolia inside offcanvas Wrapper
  • add data-bs-backdrop="false"

@julien-deramond
Copy link
Member

With data-bs-backdrop="false" we get the same result than before. Might be a quick win.
However, something doesn't work very well, when the search modal is closed by Escape key, the offcanvas doesn't get the focus automatically.

@mdo
Copy link
Member

mdo commented Jul 23, 2022

Maybe we move the search out of offcanvas and keep it visible at all times?

@mdo
Copy link
Member

mdo commented Jul 23, 2022

Example of search being outside the offcanvas:

Screen Shot 2022-07-23 at 10 58 18 AM

@GeoSot
Copy link
Member

GeoSot commented Jul 23, 2022

I would prefer it, as it is the most frequent functionality I use (and sidesolves the problem)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants