fix: Remove onnxruntime libraries from system path #7323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanmayv25
added
module: backends
tanmayv25
changed the title
kthui
approved these changes
Jun 5, 2024
krishung5
approved these changes
Jun 5, 2024
|
Can we add a test similar to #7200 ? I don't think we need to "explore if we can now use different versions of openVINO between ORT and OpenVINO backend", things will likely break if trying to load both versions / wrong version in runtime. For our published image, we should make sure the versions are aligned |
|
Yes... The test will be added in a separate PR. Verified locally that #7200 is resolved with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Removes the onnxruntime library from the system path which seemed to have been added as a workaround for openVINO EP running behind onnxruntime backend.
It has been verified with a glab pipeline with TRITON_NIGHTLY=1 that we no longer need this workaround to use the OV EP.
This might help resolve #7200.
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
Where should the reviewer start?
Test plan:
No additional tests were added. The current tests i.e. L0_onnx_optimization and l_onnx_execution_provider should provide sufficient coverage for whether the changes introduced any regressions.
#15568694
Caveats:
We can explore if we can now use different versions of openVINO between ORT and OpenVINO backend.
Background
By including the onnxruntime libraries in the system path, there is a conflict between the openvino library between ORT backends installation and the OV installed with the OV backend.
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)