Remove client testing of server trace to match discontinued support from server #7129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyastremsky
approved these changes
Apr 17, 2024
ganeshku1
reviewed
Apr 17, 2024
Separate PR. I think @dyastremsky can speak more to that: triton-inference-server/client@main...dyas-trace |
Thanks for tagging me, Matt. Yes, I'm making these changes. The PR got a bit stalled due to a failing CI. Hoping this next run resolves the issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trace settings update from client support was discontinued in #7106
This PR removes testing in PA of trace settings updating from client.