Disable Dynamic Trace File #7106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnshah1
approved these changes
Apr 12, 2024
indrajit96
reviewed
Apr 12, 2024
There was a problem hiding this comment.
If we don't support update of trace_file now
Should we clean up "filepath_specified" from the tracer..cc altogether? As filepath_specified_ will always be false?
Can take up in another PR as well as the current changes are for a PSIRT
There was a problem hiding this comment.
No. It' not. Trace file can be specified when launching tritonserver. In this case filepath_specified is true.
rmccorm4
approved these changes
Apr 12, 2024
… yinggeh-DLIS-6372-disable-dynamic-trace-file
yinggeh
added a commit
that referenced
this pull request
Apr 13, 2024
mc-nv
pushed a commit
that referenced
this pull request
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable dynamic trace file location, aka
--trace_fileAPI.