Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile.sdk with OpenAI support #6941

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Update Dockerfile.sdk with OpenAI support #6941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Dockerfile.sdk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ RUN cmake -DCMAKE_INSTALL_PREFIX=/workspace/install \
-DTRITON_ENABLE_PERF_ANALYZER_C_API=ON \
-DTRITON_ENABLE_PERF_ANALYZER_TFS=ON \
-DTRITON_ENABLE_PERF_ANALYZER_TS=ON \
-DTRITON_ENABLE_PERF_ANALYZER_OPENAI=ON \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mc-nv is this used in the CI? If so, what do I need to run to test it? If not, is there an additional place I should be applying this change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this used in the CI? If so, what do I need to run to test it?

No, It's not used by GitLab itself.

It updates cached variables -DTRITON_ENABLE_PERF_ANALYZER_OPENAI=ON. For CMake it means that the list of the variables during the runtime will be extended with provided one which may change the result outputs.

If not, is there an additional place I should be applying this change?

We generally building client repository code using Dockerfile.sdk instructions, exception is Windows SDK build, which have to be updated to ship binaries compiled with given variable -DTRITON_ENABLE_PERF_ANALYZER_OPENAI=ON.

-DTRITON_ENABLE_EXAMPLES=ON -DTRITON_ENABLE_TESTS=ON \
-DTRITON_ENABLE_GPU=${TRITON_ENABLE_GPU} /workspace/client
RUN make -j16 cc-clients python-clients java-clients && \
Expand Down
Loading