Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile.sdk with OpenAI support #6941

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Conversation

tgerdesnv
Copy link
Contributor

Add flag to enable compile of OpenAI support in PA

Add flag to enable compile of OpenAI support in PA
@tgerdesnv tgerdesnv requested a review from mc-nv March 4, 2024 22:07
@@ -127,6 +127,7 @@ RUN cmake -DCMAKE_INSTALL_PREFIX=/workspace/install \
-DTRITON_ENABLE_PERF_ANALYZER_C_API=ON \
-DTRITON_ENABLE_PERF_ANALYZER_TFS=ON \
-DTRITON_ENABLE_PERF_ANALYZER_TS=ON \
-DTRITON_ENABLE_PERF_ANALYZER_OPENAI=ON \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mc-nv is this used in the CI? If so, what do I need to run to test it? If not, is there an additional place I should be applying this change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this used in the CI? If so, what do I need to run to test it?

No, It's not used by GitLab itself.

It updates cached variables -DTRITON_ENABLE_PERF_ANALYZER_OPENAI=ON. For CMake it means that the list of the variables during the runtime will be extended with provided one which may change the result outputs.

If not, is there an additional place I should be applying this change?

We generally building client repository code using Dockerfile.sdk instructions, exception is Windows SDK build, which have to be updated to ship binaries compiled with given variable -DTRITON_ENABLE_PERF_ANALYZER_OPENAI=ON.

@tgerdesnv tgerdesnv merged commit a6ce4f6 into main Mar 11, 2024
3 checks passed
@tgerdesnv tgerdesnv deleted the tgerdes-openai-support branch March 11, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants