Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test reports to L0_json, L0_metrics, L0_response_cache, L0_backend_python #6823

Merged
merged 8 commits into from
Jan 25, 2024

Conversation

rmccorm4
Copy link
Contributor

@rmccorm4 rmccorm4 commented Jan 23, 2024

  • Generates junit test reports from various test and subtests. This is not an exhaustive list of possible CI tests, just an initial set.
    • Had to remove use of tu.TestResultCollector as it interfered with pytest usage. Wasn't able to find a quick reason/solution as to why - it involved the use of super() and certain expected object types. Reverting the classes to inheriting from unittest.TestCase directly fixed the issue.
    • Similarly, removed the use of check_test_results since the tu.TestResultCollector was no longer generating the text file with pass/fail counts. For the short term, I think the numbers shown in gitlab from the reports can replace this for now. Longer term, I think we can modify check_test_results to understand the .xml reports as well, rather than our custom .json.

Example report generated on gitlab side:
image

Copy link
Contributor

@krishung5 krishung5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Great improvements!

@rmccorm4 rmccorm4 merged commit 8fc7b10 into main Jan 25, 2024
3 checks passed
@rmccorm4 rmccorm4 deleted the rmccormick-unittest branch January 25, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants