Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test improved input validation errors #6933

Merged
merged 19 commits into from
Mar 9, 2024
Merged

Test improved input validation errors #6933

merged 19 commits into from
Mar 9, 2024

Conversation

indrajit96
Copy link
Contributor

Added new test cases and models for better input validation.
DLIS-6165

@indrajit96 indrajit96 requested a review from rmccorm4 March 1, 2024 22:56
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 1, 2024
View reviewed changes
qa/L0_input_val/input_val_test.py Fixed Show fixed Hide fixed
qa/L0_input_val/input_val_test.py Fixed Show fixed Hide fixed
qa/L0_input_val/input_val_test.py Fixed Show fixed Hide fixed
qa/L0_input_val/input_val_test.py Fixed Show fixed Hide fixed
@indrajit96 indrajit96 mentioned this pull request Mar 1, 2024
Merged
@rmccorm4 rmccorm4 changed the title Tescases and custom models for DLIS-6165 Test improved input validation errors Mar 1, 2024
@rmccorm4 rmccorm4 requested review from kthui and lkomali March 1, 2024 23:34
@rmccorm4
Copy link
Contributor

rmccorm4 commented Mar 1, 2024

Tagging @kthui @lkomali to help review

@rmccorm4
Copy link
Contributor

rmccorm4 commented Mar 1, 2024

@indrajit96 make sure to address the codeql checks above. Let's also rename the test folder to L0_input_validation to match L0_output_validation and not confuse "val" with "value"

@indrajit96
Copy link
Contributor Author

@indrajit96 make sure to address the codeql checks above. Let's also rename the test folder to L0_input_validation to match L0_output_validation and not confuse "val" with "value"

Done

kthui
kthui approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@kthui kthui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

rmccorm4
rmccorm4 approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@indrajit96 indrajit96 merged commit d89e700 into main Mar 9, 2024
3 checks passed
@indrajit96 indrajit96 deleted the indrajit_test branch March 9, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmccorm4 rmccorm4 rmccorm4 approved these changes

@kthui kthui kthui approved these changes

@lkomali lkomali Awaiting requested review from lkomali

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@indrajit96 @rmccorm4 @kthui