Tpetra: restore deprecated BlockMultiVector and BlockVector functions for #9082 #9084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getGlobalRowView in Tpetra_BlockMultiVector and Tpetra_BlockVector These functions were inadvertantly removed without deprecation during UVM removal. The functions are, however, deprecated. Users should use getLocalBlockHost with access flags instead of these functions
kddevin
added
pkg: Tpetra
AT: AUTOMERGE
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_serial
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_debug
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_10.1.105
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_10.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Using Repos:
Pull Request Author: kddevin |
kyungjoo-kim
previously approved these changes
May 3, 2021
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_serial
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_debug
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_10.1.105
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_10.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Console Output (last 100 lines) : Trilinos_pullrequest_gcc_8.3.0 # 4339 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_7.2.0_serial # 1875 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_7.2.0_debug # 2358 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_intel_17.0.1 # 9694 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_cuda_10.1.105 # 1112 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_clang_10.0.0 # 2474 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_python_3 # 5081 (click to expand) |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_serial
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_debug
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_10.1.105
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_10.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Using Repos:
Pull Request Author: kddevin |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_serial
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_debug
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_10.1.105
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_10.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Console Output (last 100 lines) : Trilinos_pullrequest_gcc_8.3.0 # 4343 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_7.2.0_serial # 1879 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_7.2.0_debug # 2362 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_intel_17.0.1 # 9698 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_cuda_10.1.105 # 1116 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_clang_10.0.0 # 2478 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_python_3 # 5085 (click to expand) |
|
I am looking at the test failures today. |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_serial
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_debug
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_10.1.105
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_10.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_10.1.105_uvm_off
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Using Repos:
Pull Request Author: kddevin |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_serial
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_debug
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_10.1.105
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_10.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_10.1.105_uvm_off
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
csiefer2
approved these changes
May 4, 2021
brian-kelley
approved these changes
May 4, 2021
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ brian-kelley csiefer2 ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Merge on Pull Request# 9084: IS A SUCCESS - Pull Request successfully merged |
trilinos-autotester
removed
the
AT: AUTOMERGE
jmgate
pushed a commit
to tcad-charon/Trilinos
that referenced
this pull request
May 5, 2021
…s:develop' (c3c9d1f). * trilinos-develop: (39 commits) Add space in CMAKE_CXX_FLAGS to be safe (trilinos#8449) Set non-cache vars for CMAKE_<LANG>_FLAGS with user override (trilinos#8449) tpetra: fixing downstream compiler errors shown in trilinos#9084 MueLu Ifpack2: Add tests for reuse and Jacobi MueLu: Reuse Chebyshev smoother tpetra: adding back and deprecating getLocalRowView and getGlobalRowView in Tpetra_BlockMultiVector and Tpetra_BlockVector These functions were inadvertantly removed without deprecation during UVM removal. The functions are, however, deprecated. Users should use getLocalBlockHost with access flags instead of these functions MueLu: correct for variation due to roundoff in Convex Hulls Disable tests listed in ticket trilinos#9077 Change name of UVM build to UVM Off Disable tests in the UVM Off build Ifpack2: Add single kernel for diagonal extraction, L1 and small entry fix KokkosKernels: Fix bug in Serial specialization of spmv Ifpack & Ifpack2: Fix tiny bug in L1 method Setting Tpetra Deprecated Code = ON trilinos#9067 Ctest: Adding Belos to email script Ctest: Adding Belos to email script Ctest: Adding Belos to email script MueLu: agg export does not play well with kokkos_aggregates ascicgpu031: Testing updates Tpetra MultiVector and BlockMultiVector refactor to remove UVM requirement (trilinos#8821) ...
jmgate
pushed a commit
to tcad-charon/Trilinos
that referenced
this pull request
May 6, 2021
…s:develop' (c3c9d1f). * trilinos-develop: (47 commits) PIRO: add accessors to the underlying loca steppers Tacho LDL for symmetric indefinite problems. (trilinos#9091) Geminga: Run on Tesla K40 only Add space in CMAKE_CXX_FLAGS to be safe (trilinos#8449) Set non-cache vars for CMAKE_<LANG>_FLAGS with user override (trilinos#8449) Xpetra: regionMG matvec function definition added to EpetraCrsMatrix tpetra: fixing downstream compiler errors shown in trilinos#9084 MueLu Ifpack2: Add tests for reuse and Jacobi MueLu: Reuse Chebyshev smoother tpetra: adding back and deprecating getLocalRowView and getGlobalRowView in Tpetra_BlockMultiVector and Tpetra_BlockVector These functions were inadvertantly removed without deprecation during UVM removal. The functions are, however, deprecated. Users should use getLocalBlockHost with access flags instead of these functions Adding xpetra shortnames header to Xpetra_TpetraCrsMatrix Add further documentation for region matvec in xpetra added small comments and removed unused lines MueLu: regionMG add a region matvec to xpetra for use with the muelu region mg MueLu: correct for variation due to roundoff in Convex Hulls Disable tests listed in ticket trilinos#9077 Change name of UVM build to UVM Off Disable tests in the UVM Off build Ifpack2: Add single kernel for diagonal extraction, L1 and small entry fix KokkosKernels: Fix bug in Serial specialization of spmv ...
searhein
added a commit
to searhein/Trilinos
that referenced
this pull request
May 6, 2021
…f-workshop * 'develop' of ssh://github.com/trilinos/Trilinos: Ifpack2 Chebyshev: Add options for power method PIRO: add accessors to the underlying loca steppers Tacho LDL for symmetric indefinite problems. (trilinos#9091) Geminga: Run on Tesla K40 only MueLu Ifpack2Smoother: Use Ifpack2 methods to set zero starting solution Ifpack2: Add methods `supportsZeroStartingSolution` and `setZeroStartingSolution` Add space in CMAKE_CXX_FLAGS to be safe (trilinos#8449) Set non-cache vars for CMAKE_<LANG>_FLAGS with user override (trilinos#8449) Xpetra: regionMG matvec function definition added to EpetraCrsMatrix tpetra: fixing downstream compiler errors shown in trilinos#9084 MueLu Ifpack2: Add tests for reuse and Jacobi MueLu: Reuse Chebyshev smoother tpetra: adding back and deprecating getLocalRowView and getGlobalRowView in Tpetra_BlockMultiVector and Tpetra_BlockVector These functions were inadvertantly removed without deprecation during UVM removal. The functions are, however, deprecated. Users should use getLocalBlockHost with access flags instead of these functions Adding xpetra shortnames header to Xpetra_TpetraCrsMatrix Add further documentation for region matvec in xpetra added small comments and removed unused lines MueLu: regionMG add a region matvec to xpetra for use with the muelu region mg
jmgate
pushed a commit
to tcad-charon/Trilinos
that referenced
this pull request
May 6, 2021
…s:develop' (c3c9d1f). * trilinos-develop: (50 commits) Ifpack2 Chebyshev: Add options for power method PIRO: add accessors to the underlying loca steppers Tacho LDL for symmetric indefinite problems. (trilinos#9091) Geminga: Run on Tesla K40 only MueLu Ifpack2Smoother: Use Ifpack2 methods to set zero starting solution Ifpack2: Add methods `supportsZeroStartingSolution` and `setZeroStartingSolution` Add space in CMAKE_CXX_FLAGS to be safe (trilinos#8449) Set non-cache vars for CMAKE_<LANG>_FLAGS with user override (trilinos#8449) Xpetra: regionMG matvec function definition added to EpetraCrsMatrix tpetra: fixing downstream compiler errors shown in trilinos#9084 MueLu Ifpack2: Add tests for reuse and Jacobi MueLu: Reuse Chebyshev smoother tpetra: adding back and deprecating getLocalRowView and getGlobalRowView in Tpetra_BlockMultiVector and Tpetra_BlockVector These functions were inadvertantly removed without deprecation during UVM removal. The functions are, however, deprecated. Users should use getLocalBlockHost with access flags instead of these functions Adding xpetra shortnames header to Xpetra_TpetraCrsMatrix Add further documentation for region matvec in xpetra added small comments and removed unused lines MueLu: regionMG add a region matvec to xpetra for use with the muelu region mg MueLu: correct for variation due to roundoff in Convex Hulls Disable tests listed in ticket trilinos#9077 Change name of UVM build to UVM Off ...
jmgate
pushed a commit
to tcad-charon/Trilinos
that referenced
this pull request
May 6, 2021
…s:develop' (c3c9d1f). * trilinos-develop: (50 commits) Ifpack2 Chebyshev: Add options for power method PIRO: add accessors to the underlying loca steppers Tacho LDL for symmetric indefinite problems. (trilinos#9091) Geminga: Run on Tesla K40 only MueLu Ifpack2Smoother: Use Ifpack2 methods to set zero starting solution Ifpack2: Add methods `supportsZeroStartingSolution` and `setZeroStartingSolution` Add space in CMAKE_CXX_FLAGS to be safe (trilinos#8449) Set non-cache vars for CMAKE_<LANG>_FLAGS with user override (trilinos#8449) Xpetra: regionMG matvec function definition added to EpetraCrsMatrix tpetra: fixing downstream compiler errors shown in trilinos#9084 MueLu Ifpack2: Add tests for reuse and Jacobi MueLu: Reuse Chebyshev smoother tpetra: adding back and deprecating getLocalRowView and getGlobalRowView in Tpetra_BlockMultiVector and Tpetra_BlockVector These functions were inadvertantly removed without deprecation during UVM removal. The functions are, however, deprecated. Users should use getLocalBlockHost with access flags instead of these functions Adding xpetra shortnames header to Xpetra_TpetraCrsMatrix Add further documentation for region matvec in xpetra added small comments and removed unused lines MueLu: regionMG add a region matvec to xpetra for use with the muelu region mg MueLu: correct for variation due to roundoff in Convex Hulls Disable tests listed in ticket trilinos#9077 Change name of UVM build to UVM Off ...
seamill
pushed a commit
to seamill/Trilinos
that referenced
this pull request
Jul 28, 2021
…develop' (2d91d5f). * trilinos/develop: Add space in CMAKE_CXX_FLAGS to be safe (trilinos#8449) Set non-cache vars for CMAKE_<LANG>_FLAGS with user override (trilinos#8449) tpetra: fixing downstream compiler errors shown in trilinos#9084 MueLu Ifpack2: Add tests for reuse and Jacobi MueLu: Reuse Chebyshev smoother tpetra: adding back and deprecating getLocalRowView and getGlobalRowView in Tpetra_BlockMultiVector and Tpetra_BlockVector These functions were inadvertantly removed without deprecation during UVM removal. The functions are, however, deprecated. Users should use getLocalBlockHost with access flags instead of these functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trilinos/tpetra
Functions getLocalRowView and getGlobalRowView were removed without deprecation from BlockMultiVector and BlockVector. This removal without deprecation was reported in #9082. This PR restores the functions.
However, users should migrate away from use of BlockMultiVector's getLocalRowView and getGlobalRowView, as they are deprecated. These functions are completely unsafe with UVM is disabled; their returning of a raw data pointer is not allowed in non-UVM Tpetra.
This PR also renames getLocalBlock to getLocalBlockHost, to more accurately reflect what is returned (and, indeed, what has always been returned by getLocalBlock, getLocalRowView and getGlobalRowView).
Motivation
Following Trilinos' deprecation policy.
Related Issues
Stakeholder Feedback
@tcfisher please let us know whether this PR resolves #9082
Testing
ascicgpu with UVM and Deprecated code; ascicgpu without UVM