Tpetra: Why remove instead of deprecate getLocalRowView?

[tcfisher]

Question

@trilinos/tpetra
@kddevin
@ccober6

The commit, 34a0760, has broken SPARC because SPARC uses getLocalRowView from TpetraBlockVector and TpetraBlockCrs. A lot of code was moved to deprecated when new interfaces were added. Why wasn't this made deprecated instead of removed?

What is the correct translation to transition from getLocalRowView to getBlock?

Thanks,

Travis

[jhux2]

@trilinos/tpetra

[kddevin]

Removing without deprecation was likely a mistake. I'll restore it this afternoon unless there is a serious problem that led to the removal. Thanks for the report; sorry for the inconvenience.
@tcfisher

[kddevin]

@tcfisher #9084 restores the missing functions. Note, however, that these functions will be deprecated.
Instead of saying

scalar *x;
mv.getLocalRowView(row, col, x);

you should do

auto x = mv.getLocalBlockHost(row, col, Access::ReadOnly);

or

auto x = mv.getLocalBlockHost(row, col, Access::ReadWrite);

The access tag says how you intend to use the returned view -- as read-only (const) data or read-write (non-const) data.

Deprecated function getLocalBlock, getLocalRowView and getGlobalRowViews were returning host data. Please let me know if you need device versions of getLocalBlock. Or if you have suggestions for better block interfaces, let us know.

Note that similar changes will happen for BlockCrsMatrix. @kyungjoo-kim is working on BlockCrsMatrix now.

[tcfisher]

Thanks @kddevin, we will try to transition to the new interface soon. We were only using this on the host.

[kddevin]

Fixed by #9084