Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tpetra: add missing fence in WrappedDualView #8973

Merged
merged 2 commits into from
Apr 5, 2021
Merged

Tpetra: add missing fence in WrappedDualView #8973

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aad2d3e
Tpetra: add a fence when WrappedDualView is doing OverwriteAll on hos…
tasmith4 Apr 5, 2021
deed0a5
Tpetra: cleanup fence in WrappedDualView
tasmith4 Apr 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/tpetra/core/src/Tpetra_Details_WrappedDualView.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,13 +113,16 @@ sync_device(DualViewType dualView) { }

template <typename DualViewType>
class WrappedDualView {
private:
static constexpr bool dualViewHasNonConstData = !impl::hasConstData<DualViewType>::value;

public:
using HostViewType = typename DualViewType::t_host;
using DeviceViewType = typename DualViewType::t_dev;

private:
static constexpr bool dualViewHasNonConstData = !impl::hasConstData<DualViewType>::value;
static constexpr bool deviceMemoryIsHostAccessible =
Kokkos::SpaceAccessibility<Kokkos::Serial, typename DeviceViewType::memory_space>::accessible;

public:
WrappedDualView() {}

WrappedDualView(DualViewType dualV)
Expand Down Expand Up @@ -184,6 +187,7 @@ class WrappedDualView {
return getHostView(Access::ReadWrite);
}
throwIfDeviceViewAlive();
if (deviceMemoryIsHostAccessible) Kokkos::fence();
dualView.clear_sync_state();
dualView.modify_host();
return dualView.view_host();
Expand Down