Tpetra: add missing fence in WrappedDualView #8973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasmith4
added
pkg: Tpetra
AT: AUTOMERGE
kddevin
approved these changes
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trilinos/tpetra
When we get the host view of a WrappedDualView with OverwriteAll, a device kernel is potentially still changing values on the device view, but we don't care because we're overwriting them anyway. In UVM though, we need to wait to overwrite on host until device is done writing, because otherwise the things we write on host could be overwritten by the device kernel that hasn't finished yet.
Testing
The need for this change was exposed by an existing WrappedDualView test.