Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROL: obey provided Secant in TrustRegionStep #8737

Closed
wants to merge 1 commit into from
Closed

ROL: obey provided Secant in TrustRegionStep #8737

wants to merge 1 commit into from

Conversation

angus-g
Copy link

@angus-g angus-g commented Feb 11, 2021

@trilinos/rol

Motivation

Although one of the TrustRegionStep initializers accepts a Secant pointer, in line with other Steps, it was being ignored. This two- argument initializer doesn't seem to actually be used anywhere, so this issue wouldn't have been causing any problems.

Related Issues

@angus-g
ROL: obey provided Secant in TrustRegionStep
a6422ca 
Although one of the TrustRegionStep initializers accepts a Secant
pointer, in line with other Steps, it was being ignored. This two-
argument initializer doesn't seem to actually be used anywhere, so
this issue wouldn't have been causing any problems.
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
WARNING: NO REVIEWERS HAVE BEEN REQUESTED FOR THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

@bartlettroscoe bartlettroscoe mentioned this pull request Aug 21, 2022
Closed
@github-actions
Copy link

This Pull Request has been marked for closure due to inactivity.
Because of the changing nature of the Trilinos source due to active development, a pull request with no activity for 365 days is considered to be abandoned and will be automatically closed after 30 additional days of inactivity from when it was marked inactive.
If this should be kept open, please post a comment and/or remove the label MARKED_FOR_CLOSURE to reset the inactivity timer.
If it is ok for this pull request to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

@github-actions github-actions bot added the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label Oct 29, 2022
@github-actions
Copy link

This Pull Request has been automatically closed due to 395 days of inactivity.

@github-actions github-actions bot added the CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. label Nov 30, 2022
@github-actions github-actions bot closed this Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@angus-g @trilinos-autotester