ROL: Secant parameter is ignored in TrustRegionStep initializer

[angus-g]

Bug Report

@trilinos/rol

Description

ROL::TrustRegionStep has a two-argument initializer which takes an additional secant parameter, similar to other Steps. This parameter is however ignored and the secant_ member is always initialized to a null-pointer, which then causes it to be initialized with the default method. This two-argument initializer doesn't seem to be used anywhere, in the package itself, but the behaviour seems to be unwarranted nonetheless.

Steps to Reproduce

1. Create an instance of a ROL::Secant
2. Call ROL::TrustRegionStep(secant, params)
3. An L-BFGS secant is created and the provided one is ignored.

[github-actions]

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

[github-actions]

This issue was closed due to inactivity for 395 days.