Fix change logic in get-changed-trilinos-packages.sh and PullRequestLinuxDriver.sh (#3133) #3258

bartlettroscoe · 2018-08-08T18:35:21Z

@trilinos/framework

Description

This PR contains two sets of commits.

The first set of commits fixes the behavior of the get-changed-trilinos-packages.sh script to apply the correct global change logic for Trilinos. This updates TriBITS snapshot and adds unit test to ensure that the logic in the file Trilinos/cmake/ProjectCiFileChangeLogic.py is getting correctly applied in the script get-changed-trilinos-packages.sh used by the Trilinos PR tester. The unit testing of get-changed-trilinos-packages.sh was not strong enough.

The second set of changes in the commit b2cccbf which passes in the correct SHA1 for selecting the set of changed files in the script PullRequestLinuxDriver.sh. See #3265.

Motivation and Context

The TriBITS scripts called by get-changed-trilinos-packages.sh were not pickup up the logic in Trilinos/cmake/ProjectCiFileChangeLogic.py and was instead likely using the logic in TribitsExampleProject/cmake/ProjectCiFileChangeLogic.py (see TriBITSPub/TriBITS@9b9822f). As a result, PRs like #3251 were incorrectly triggering the enable of all Trilinos packages.

Also the modification to PullRequestLinuxDriver.sh in PR #3218 was using the wrong base SHA1 and was resulting in testing more packages than needed for the PR in many cases (see #3265).

The merge of this PR should complete #3133.

How Has This Been Tested?

I expanded the unit tests for get-changed-trilinos-packages.sh to ensure it ignores a change to a *.cmake file under the cmake/std/adm/ directory. I also ran the script manually for a few PRs, including #3251, and saw that it is selecting the right packages to test (and no package in the case of PR #3251).

To test this updated script PullRequestLinuxDriver.sh, I did the following.

First, I created the separate dummy PR testing repo where the PR branch merges are done:

$ cd ~/junk/DummyTrilinosPRDriver
$ ls
Trilinos
$ cd Trilinos/
$ git remote -v
origin  [email protected]:trilinos/Trilinos.git (fetch)
origin  [email protected]:trilinos/Trilinos.git (push)

The I just ran the script PullRequestLinuxDriver.sh on this for a few real PRs.

First, I tested this for the PR #3260:

$ env \
  TRILINOS_SOURCE_BRANCH=tril-215-white-ride-cuda-9.2 \
  TRILINOS_SOURCE_REPO=https://github.com/bartlettroscoe/Trilinos \
  TRILINOS_SOURCE_SHA=c96c475fbbc3162e4618050c3e893dcb107a73e1 \
  TRILINOS_TARGET_BRANCH=develop \
  TRILINOS_TARGET_REPO=https://github.com/trilinos/Trilinos \
  TRILINOS_TARGET_SHA=45adc9002091ba1fc6ae296c72696f8717b8b885 \
  PULLREQUESTNUM=111 \
  JOB_BASE_NAME=Trilinos_pullrequest_gcc_4.8.4 \
  BUILD_NUMBER=222 \
  WORKSPACE=$PWD \
 ~/Trilinos.base/Trilinos/cmake/std/PullRequestLinuxDriver.sh \
 &> console.out

$ cmake -P packageEnables.cmake 
-- NOTE: No packages are being enabled!

That is the correct set of enables (i.e. no enables). That will save me huge amounts of time (and would have allowed PR #3260 to be merged immediately).

Then I tested this for a few other PRs ...

Testing for PR #3275:

$ env \
  TRILINOS_SOURCE_BRANCH=sacado_cppunit_fix \
  TRILINOS_SOURCE_REPO=https://github.com/etphipp/Trilinos \
  TRILINOS_SOURCE_SHA=3fce9c6d41039f78d6f8def4d404e234ea06449a \
  TRILINOS_TARGET_BRANCH=develop \
  TRILINOS_TARGET_REPO=https://github.com/trilinos/Trilinos \
  TRILINOS_TARGET_SHA=4956217a66dba575a6c422dd43b6b2586fe85476 \
  PULLREQUESTNUM=111 \
  JOB_BASE_NAME=Trilinos_pullrequest_gcc_4.8.4 \
  BUILD_NUMBER=222 \
  WORKSPACE=$PWD \
 ~/Trilinos.base/Trilinos/cmake/std/PullRequestLinuxDriver.sh \
 &> console.out

$ cmake -P packageEnables.cmake 
-- Setting Trilinos_ENABLE_Sacado = ON

That looks correct.

Testing for PR #2930:

$ env \
  TRILINOS_SOURCE_BRANCH=import_stk \
  TRILINOS_SOURCE_REPO=https://github.com/prwolfe/Trilinos \
  TRILINOS_SOURCE_SHA=b2674b6c78f0ca1b0f6c3b79be1e7f5a18d9a34a \
  TRILINOS_TARGET_BRANCH=develop \
  TRILINOS_TARGET_REPO=https://github.com/trilinos/Trilinos \
  TRILINOS_TARGET_SHA=45adc9002091ba1fc6ae296c72696f8717b8b885 \
  PULLREQUESTNUM=111 \
  JOB_BASE_NAME=Trilinos_pullrequest_gcc_4.8.4 \
  BUILD_NUMBER=222 \
  WORKSPACE=$PWD \
 ~/Trilinos.base/Trilinos/cmake/std/PullRequestLinuxDriver.sh \
 &> console.out

$ cmake -P packageEnables.cmake 
-- Setting Trilinos_ENABLE_STK = ON
-- Setting Trilinos_ENABLE_STKDoc_tests = ON
-- Setting Trilinos_ENABLE_STKExprEval = ON
-- Setting Trilinos_ENABLE_STKIO = ON
-- Setting Trilinos_ENABLE_STKMesh = ON
-- Setting Trilinos_ENABLE_STKSearch = ON
-- Setting Trilinos_ENABLE_STKSearchUtil = ON
-- Setting Trilinos_ENABLE_STKSimd = ON
-- Setting Trilinos_ENABLE_STKTools = ON
-- Setting Trilinos_ENABLE_STKTopology = ON
-- Setting Trilinos_ENABLE_STKTransfer = ON
-- Setting Trilinos_ENABLE_STKUnit_test_utils = ON
-- Setting Trilinos_ENABLE_STKUnit_tests = ON
-- Setting Trilinos_ENABLE_STKUtil = ON

That looks correct. (FYI @prwolfe)

Testing for PR #3258: (Prior to updating the branch and the PR)

$ env \
  TRILINOS_SOURCE_BRANCH=3133-fix-logic \
  TRILINOS_SOURCE_REPO=https://github.com/bartlettroscoe/Trilinos \
  TRILINOS_SOURCE_SHA=b2cccbf5f5b2f56d31ce7fa2ae6c4957c938427c \
  TRILINOS_TARGET_BRANCH=develop \
  TRILINOS_TARGET_REPO=https://github.com/trilinos/Trilinos \
  TRILINOS_TARGET_SHA=45adc9002091ba1fc6ae296c72696f8717b8b885 \
  PULLREQUESTNUM=111 \
  JOB_BASE_NAME=Trilinos_pullrequest_gcc_4.8.4 \
  BUILD_NUMBER=222 \
  WORKSPACE=$PWD \
 ~/Trilinos.base/Trilinos/cmake/std/PullRequestLinuxDriver.sh \
 &> console.out

$ cmake -P packageEnables.cmake
-- Setting Trilinos_ENABLE_ALL_PACKAGES = ON
-- Setting Trilinos_ENABLE_TrilinosFrameworkTests = ON

That looks like the correct set of enables for the set of files that are being changed in that (this) PR.

Checklist

My commit messages mention the appropriate GitHub issue numbers.
I have added tests to cover my changes.
All new and existing tests passed.

Origin repo remote tracking branch: 'github/master' Origin repo remote repo URL: 'github = [email protected]:TriBITSPub/TriBITS.git' At commit: commit a4f290fc95ee746bfee71f82a7bde5ad4c7db6b5 Author: Roscoe A. Bartlett <[email protected]> Date: Mon Jul 23 10:05:41 2018 -0600 Summary: Fix some doc typos (trilinos#3133)

Origin repo remote tracking branch: 'github/master' Origin repo remote repo URL: 'github = [email protected]:TriBITSPub/TriBITS.git' At commit: commit 9b9822f5f2ab7183bdc47eec2193a5fbf6ab83d1 Author: Roscoe A. Bartlett <[email protected]> Date: Wed Aug 8 10:40:15 2018 -0600 Summary: Find ProjectCiFileChangeLogic.py for all projects (trilinos#3133)

…nos#3133) This addresses a defect in the usage of Trilinos/cmake/ProjectCiFileChangeLogic.py. Before, it was not getting found for Trilinos.

trilinos-autotester · 2018-08-08T18:43:31Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

trilinos-autotester · 2018-08-08T18:44:16Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

Build Num: 1301
Status: STARTED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.9.3
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`0be70b9`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`45adc90`

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Build Num: 995
Status: STARTED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.8.4
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`0be70b9`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`45adc90`

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Build Num: 546
Status: STARTED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`0be70b9`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`45adc90`

Using Repos:

Repo: TRILINOS (bartlettroscoe/Trilinos)

Pull Request Author: bartlettroscoe

trilinos-autotester · 2018-08-08T20:17:27Z

Status Flag 'Pull Request AutoTester' - Error: Jenkins Jobs - A user has commited a change to the PR before testing completed. The original testing SHA = 0be70b9 Does not match the current commit SHA = ed2709d. The Jenkins Jobs will be shutdown; Testing of this PR must occur again.

trilinos-autotester · 2018-08-08T20:18:04Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED

Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run.

Pull Request Auto Testing has FAILED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

Build Num: 1301
Status: ERROR

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.9.3
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`0be70b9`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`45adc90`

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Build Num: 995
Status: ERROR

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.8.4
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`0be70b9`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`45adc90`

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Build Num: 546
Status: ERROR

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`0be70b9`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`45adc90`

CDash Test Results for PR# 3258.

trilinos-autotester · 2018-08-08T20:29:48Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

trilinos-autotester · 2018-08-08T20:31:11Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

Build Num: 1303
Status: STARTED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.9.3
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`ed2709d`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`45adc90`

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Build Num: 997
Status: STARTED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.8.4
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`ed2709d`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`45adc90`

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Build Num: 548
Status: STARTED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`ed2709d`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`45adc90`

Using Repos:

Repo: TRILINOS (bartlettroscoe/Trilinos)

Pull Request Author: bartlettroscoe

trilinos-autotester · 2018-08-09T01:15:08Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

Build Num: 1303
Status: PASSED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.9.3
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`ed2709d`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`45adc90`

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Build Num: 997
Status: PASSED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.8.4
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`ed2709d`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`45adc90`

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Build Num: 548
Status: PASSED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`ed2709d`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`45adc90`

CDash Test Results for PR# 3258.

trilinos-autotester · 2018-08-09T01:15:27Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

trilinos-autotester · 2018-08-09T01:15:35Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

bartlettroscoe · 2018-08-09T13:37:17Z

@william76, can you please review this updated PR? It fixes two sets of problems with the auto PR testing logic.

trilinos-autotester · 2018-08-09T13:41:32Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

trilinos-autotester · 2018-08-09T13:43:02Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

Build Num: 1317
Status: STARTED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.9.3
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`b2cccbf`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`45adc90`

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Build Num: 1011
Status: STARTED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.8.4
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`b2cccbf`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`45adc90`

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Build Num: 562
Status: STARTED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`b2cccbf`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`45adc90`

Using Repos:

Repo: TRILINOS (bartlettroscoe/Trilinos)

Pull Request Author: bartlettroscoe

bartlettroscoe · 2018-08-09T14:35:54Z

So it looks like the Trilinos auto PR tester does not use the script PullRequestLinuxDriver.sh in the branch to drive testing. It must use a version of the 'develop' branch or something. You can see this in current PR testing iteration here which shows:

loading initial cache file /scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_4.9.3/packageEnables.cmake
-- Setting Trilinos_ENABLE_ALL_PACKAGES = ON
-- Setting Trilinos_ENABLE_TrilinosFrameworkTests = ON
-- Setting Trilinos_ENABLE_Belos = ON
-- Setting Trilinos_ENABLE_TpetraCore = ON

That is not the right set of enables for the changes in the PR. There are no changes to Belos or TpetraCore.

william76 · 2018-08-09T15:19:57Z

@bartlettroscoe
I'm not sure I'm following your previous comment, what do you mean that PullRequestLinuxDriver.sh isn't being used?

bartlettroscoe · 2018-08-09T15:36:01Z

I'm not sure I'm following your previous comment, what do you mean that PullRequestLinuxDriver.sh isn't being used?

@william76, I just mean that PullRequestLinuxDriver.sh is not getting used in the GCC 4.8.4 + OpenMP RP build as we discussed on Monday.

trilinos-autotester · 2018-08-10T10:39:48Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

Build Num: 1327
Status: STARTED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.9.3
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`c0a42fc`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`4b95749`

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Build Num: 1021
Status: STARTED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.8.4
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`c0a42fc`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`4b95749`

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Build Num: 572
Status: STARTED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`c0a42fc`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`4b95749`

Using Repos:

Repo: TRILINOS (bartlettroscoe/Trilinos)

Pull Request Author: bartlettroscoe

bartlettroscoe · 2018-08-10T12:21:38Z

@trilinos/framework,

The latest testing iteration for this PR shown here shows empty configure output and nothing else.

Can someone look at the Jenkins logs to see what might have happened? Is there a way that non Trilinos framework people can directly view the Jenkins logs?

allevin · 2018-08-10T12:57:27Z

@bartlettroscoe Ross, we are working on an improvement to the autotester to dump the last 100 lines of the log of each of the Jenkins runs into the Github Failed test report created by the AT. It's not the same as having actual Jenkins access, but it might help out. We need to do a bit more testing, but hopefully soon we can introduce it into the system.

bartlettroscoe · 2018-08-10T13:31:31Z

Ross, we are working on an improvement to the autotester to dump the last 100 lines of the log of each of the Jenkins runs into the Github Failed test report created by the AT

@allevin, could the AT just attach the entire Jenkins job output as a file attachment with a *.txt extension or something? That would not clutter up PR comments but would provide everything anyone would need to diagnose what was happening.

trilinos-autotester · 2018-08-10T13:45:44Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED

Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run.

Pull Request Auto Testing has FAILED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

Build Num: 1327
Status: FAILED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.9.3
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`c0a42fc`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`4b95749`

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Build Num: 1021
Status: FAILED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.8.4
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`c0a42fc`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`4b95749`

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Build Num: 572
Status: PASSED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`c0a42fc`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`4b95749`

CDash Test Results for PR# 3258.

Now the Jenkins job output should be able to show what packages will be enabled even before the ctest -S driver script is run.

trilinos-autotester · 2018-08-10T14:00:34Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

trilinos-autotester · 2018-08-10T14:01:24Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

Build Num: 1328
Status: STARTED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.9.3
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`3f64f94`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`4b95749`

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Build Num: 1022
Status: STARTED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.8.4
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`3f64f94`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`4b95749`

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Build Num: 573
Status: STARTED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`3f64f94`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`4b95749`

Using Repos:

Repo: TRILINOS (bartlettroscoe/Trilinos)

Pull Request Author: bartlettroscoe

trilinos-autotester · 2018-08-10T17:26:39Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED

Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run.

Pull Request Auto Testing has FAILED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

Build Num: 1328
Status: FAILED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.9.3
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`3f64f94`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`4b95749`

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Build Num: 1022
Status: FAILED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.8.4
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`3f64f94`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`4b95749`

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Build Num: 573
Status: PASSED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`3f64f94`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`4b95749`

CDash Test Results for PR# 3258.

allevin · 2018-08-10T17:53:28Z

@allevin, could the AT just attach the entire Jenkins job output as a file attachment with a *.txt extension or something? That would not clutter up PR comments but would provide everything anyone would need to diagnose what was happening.

@bartlettroscoe I looked into this a bit this morning... Basically it looks like the Github API does not allow uploading files as issue attachments (see this response from Github). I also don't see any way to do is via PyGithub. I will ping some of the developers at PyGithub and see if they are aware of anyway to do it. I suspect they don't want automated systems to dump huge files onto their servers.

trilinos-autotester · 2018-08-10T20:01:44Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

Build Num: 1333
Status: STARTED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.9.3
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`3f64f94`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`4b95749`

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Build Num: 1027
Status: STARTED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.8.4
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`3f64f94`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`4b95749`

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Build Num: 576
Status: STARTED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`3f64f94`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`4b95749`

Using Repos:

Repo: TRILINOS (bartlettroscoe/Trilinos)

Pull Request Author: bartlettroscoe

bartlettroscoe · 2018-08-10T20:46:04Z

Basically it looks like the Github API does not allow uploading files as issue attachments (see this response from Github). I also don't see any way to do is via PyGithub. I will ping some of the developers at PyGithub and see if they are aware of anyway to do it. I suspect they don't want automated systems to dump huge files onto their servers.

@allevin, thanks for checking on this. That makes sense. Another option is to put the log file contents into a <details> ... </details> block a the very bottom of the comment. That way, it will not bother anyone unless they want to see it. But getting the last 100 lines might be enough to help. Thanks!

allevin · 2018-08-10T21:04:45Z

@allevin, thanks for checking on this. That makes sense. Another option is to put the log file contents into a
...
block a the very bottom of the comment. That way, it will not bother anyone unless they want to see it. But getting the last 100 lines might be enough to help. Thanks!

That's exactly what we are doing.

trilinos-autotester · 2018-08-11T00:26:27Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

Build Num: 1333
Status: PASSED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.9.3
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`3f64f94`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`4b95749`

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Build Num: 1027
Status: PASSED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.8.4
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`3f64f94`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`4b95749`

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Build Num: 576
Status: PASSED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	3258
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3133-fix-logic
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`3f64f94`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`4b95749`

CDash Test Results for PR# 3258.

trilinos-autotester · 2018-08-11T00:26:46Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS NOT BEEN REVIEWED YET!

trilinos-autotester · 2018-08-11T00:26:54Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

trilinos-autotester · 2018-08-12T00:39:16Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

trilinos-autotester · 2018-08-13T00:59:14Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

trilinos-autotester · 2018-08-14T00:59:19Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

jwillenbring

I reviewed these changes and they seem consistent with what was discussed at the TriBITS/Trilinos meeting this week. I approve.

trilinos-autotester · 2018-08-15T00:49:57Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ jwillenbring ]!

trilinos-autotester · 2018-08-15T00:50:07Z

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

trilinos-autotester · 2018-08-15T00:50:12Z

Merge on Pull Request# 3258: IS A SUCCESS - Pull Request successfully merged

trilinos#3133, trilinos#3265) Now calling this script will select the correct set of file changes and correct set of enables as part the goals of trilinos#3133. I have tested this manally on several different PRs and verified that the correct set of enables are being selected. I did a few other things while editing the script: * The script can now be run on a different scratch Trilinos repo. This allows it to be manually tested without messing up the status of your main Trilinos git repo (see details in PR trilinos#3258) * The Trilinos git repo where the PR branch is merged is now automatically updated to the correct state, no matter what its prior state is before it is run. The only requirement is that the 'origin' remote is set correctly. None of the other local branches have to be exist or set correctly at all. See the new comments at the top. * Make all formating if statements the same with the same indentation. * Removed code that was not used or did nothing. Without this change, the auto PR tester will test more package that is it supposed to.

bartlettroscoe added 3 commits July 23, 2018 10:25

Merge branch 'tribits_github_snapshot' into 3133-fix-logic-tmp (trili…

3972ddb

…nos#3133) This addresses a defect in the usage of Trilinos/cmake/ProjectCiFileChangeLogic.py. Before, it was not getting found for Trilinos.

bartlettroscoe added Framework tasks Framework tasks (used internally by Framework team) client: ATDM Any issue primarily impacting the ATDM project labels Aug 8, 2018

bartlettroscoe added this to the Improve productivity, stability, and quality of Trilinos milestone Aug 8, 2018

bartlettroscoe requested review from william76 and jwillenbring August 8, 2018 18:35

bartlettroscoe added the stage: in progress Work on the issue has started label Aug 8, 2018

bartlettroscoe mentioned this pull request Aug 8, 2018

Get Trilinos auto PR testing code to use TriBITS-based package enable logic #3133

Closed

This was referenced Aug 9, 2018

Test ShyLU_NodeTacho_Tacho_TestSerial_double_MPI_1 randomly failing in CI and PR GCC 4.8.4 + OpenMP builds #3263

Closed

Problems with autotester SHA1s passed into get-changed-trilinos-packages.sh in Trilinos auto-tester #3265

Closed

bartlettroscoe changed the title ~~Correctly use Trilinos/cmake/ProjectCiFileChangeLogic.py in get-changed-trilinos-packages.sh (#3133)~~ Fix change logic in get-changed-trilinos-packages.sh and auto PR tester (#3133) Aug 9, 2018

bartlettroscoe changed the title ~~Fix change logic in get-changed-trilinos-packages.sh and auto PR tester (#3133)~~ Fix change logic in get-changed-trilinos-packages.sh and PullRequestLinuxDriver.sh (#3133) Aug 9, 2018

mhoemmen previously approved these changes Aug 9, 2018

View reviewed changes

Print list of enabled packages and add comment on diff (trilinos#3133)

3f64f94

Now the Jenkins job output should be able to show what packages will be enabled even before the ctest -S driver script is run.

bartlettroscoe mentioned this pull request Aug 10, 2018

Trilinos auto PR tester stability issues #3276

Closed

bartlettroscoe mentioned this pull request Aug 10, 2018

Switch post-push CI build to use all-at-once method (#1761) #3283

Merged

jwillenbring approved these changes Aug 14, 2018

View reviewed changes

jwillenbring added the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Aug 14, 2018

trilinos-autotester merged commit b952d7a into trilinos:develop Aug 15, 2018

trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Aug 15, 2018

bartlettroscoe removed the stage: in progress Work on the issue has started label Aug 15, 2018

Fix change logic in get-changed-trilinos-packages.sh and PullRequestLinuxDriver.sh (#3133) #3258

Fix change logic in get-changed-trilinos-packages.sh and PullRequestLinuxDriver.sh (#3133) #3258

Conversation

bartlettroscoe commented Aug 8, 2018 • edited Loading

Description

Motivation and Context

How Has This Been Tested?

Checklist

trilinos-autotester commented Aug 8, 2018

trilinos-autotester commented Aug 8, 2018

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Jenkins Parameters

Using Repos:

trilinos-autotester commented Aug 8, 2018

trilinos-autotester commented Aug 8, 2018

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Jenkins Parameters

trilinos-autotester commented Aug 8, 2018

trilinos-autotester commented Aug 8, 2018

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Jenkins Parameters

Using Repos:

trilinos-autotester commented Aug 9, 2018

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Jenkins Parameters

trilinos-autotester commented Aug 9, 2018

trilinos-autotester commented Aug 9, 2018

bartlettroscoe commented Aug 9, 2018

trilinos-autotester commented Aug 9, 2018

trilinos-autotester commented Aug 9, 2018

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Jenkins Parameters

Using Repos:

bartlettroscoe commented Aug 9, 2018

william76 commented Aug 9, 2018

bartlettroscoe commented Aug 9, 2018

trilinos-autotester commented Aug 10, 2018

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

bartlettroscoe commented Aug 8, 2018 •

edited

Loading