Consolidate disables for all builds on 'mutrino' (#3183) #3251

bartlettroscoe · 2018-08-07T20:34:25Z

Description

This also adds back the disables for several SEACAS tests that got removed
when the file INTEL-RELEASE-OPENMP.cmake got renamed to the file
INTEL-RELEASE-OPENMP-HSW.cmake (not clear how that happened).

Motivation and Context

The disables for the build intel-opt-openmp-HSW got removed on the file rename which resulted in these tests failing again in this build (see #3183) and this much duplication is bad. We want less duplication.

How Has This Been Tested?

I ran local configures with:

$  ./checkin-test-atdm.sh all --enable-packages=SEACAS --configure

which returned:

PASSED (NOT READY TO PUSH): Trilinos: mutrino

Tue Aug  7 14:33:08 MDT 2018

Enabled Packages: SEACAS

Build test results:
-------------------
0) MPI_RELEASE_DEBUG_SHARED_PT_OPENMP => Test case MPI_RELEASE_DEBUG_SHARED_PT_OPENMP was not run! => Does not affect push readiness! (-1.00 min)
1) intel-debug-openmp-HSW => passed: configure-only passed => Not ready to push! (1.21 min)
2) intel-opt-openmp-HSW => passed: configure-only passed => Not ready to push! (1.23 min)
3) intel-debug-openmp-KNL => passed: configure-only passed => Not ready to push! (1.67 min)
4) intel-opt-openmp-KNL => passed: configure-only passed => Not ready to push! (1.57 min)

For the build intel-opt-openmp-HSW for example, the configure output showed:

-- Including ATDM build treaks file /home/rabartl/Trilinos.base/Trilinos/cmake/std/atdm/mutrino/tweaks/INTEL-RELEASE-OPENMP-HSW.cmake ...
-- Setting default Piro_MatrixFreeDecorator_UnitTests_MPI_4_DISABLE=ON
-- Setting default MueLu_CreateOperatorTpetra_MPI_1_DISABLE=ON
-- Setting default MueLu_CreateOperatorTpetra_MPI_4_DISABLE=ON
-- Setting default MueLu_ParameterListInterpreterTpetra_MPI_1_DISABLE=ON
-- Setting default MueLu_ParameterListInterpreterTpetra_MPI_4_DISABLE=ON
-- Setting default MueLu_ParameterListInterpreterTpetraHeavy_MPI_1_DISABLE=ON
-- Setting default MueLu_ParameterListInterpreterTpetraHeavy_MPI_4_DISABLE=ON
-- Setting default SEACASAprepro_aprepro_array_test_DISABLE=ON
-- Setting default SEACASAprepro_aprepro_command_line_include_test_DISABLE=ON
-- Setting default SEACASAprepro_aprepro_command_line_vars_test_DISABLE=ON
-- Setting default SEACASAprepro_aprepro_test_dump_reread_DISABLE=ON
-- Setting default SEACASAprepro_aprepro_unit_test_DISABLE=ON
-- Setting default SEACASAprepro_lib_aprepro_lib_array_test_DISABLE=ON
-- Setting default SEACASAprepro_lib_aprepro_lib_unit_test_DISABLE=ON
-- Setting default SEACASExodus_exodus_unit_tests_nc5_env_DISABLE=ON
-- Setting default SEACASExodus_exodus_unit_tests_DISABLE=ON

That looks like the right set of disables.

Checklist

My commit messages mention the appropriate GitHub issue numbers.

This also adds back the disables for several SEACAS tests that got removed when the file INTEL-RELEASE-OPENMP.cmake got renamed to the file INTEL-RELEASE-OPENMP-HSW.cmake (not clear how that happened).

trilinos-autotester · 2018-08-07T20:50:52Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

trilinos-autotester · 2018-08-07T20:51:40Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

Build Num: 1277
Status: STARTED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.9.3
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	3251
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3183-disable-seacas-tests
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`ec6ffd6`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2b049a2`

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Build Num: 971
Status: STARTED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.8.4
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	3251
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3183-disable-seacas-tests
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`ec6ffd6`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2b049a2`

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Build Num: 522
Status: STARTED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	3251
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3183-disable-seacas-tests
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`ec6ffd6`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2b049a2`

Using Repos:

Repo: TRILINOS (bartlettroscoe/Trilinos)

Pull Request Author: bartlettroscoe

trilinos-autotester · 2018-08-08T01:51:08Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

Build Num: 1277
Status: PASSED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.9.3
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	3251
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3183-disable-seacas-tests
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`ec6ffd6`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2b049a2`

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Build Num: 971
Status: PASSED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.8.4
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	3251
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3183-disable-seacas-tests
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`ec6ffd6`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2b049a2`

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Build Num: 522
Status: PASSED

Jenkins Parameters

Parameter Name	Value
PULLREQUESTNUM	3251
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	3183-disable-seacas-tests
TRILINOS_SOURCE_REPO	https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA	`ec6ffd6`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2b049a2`

CDash Test Results for PR# 3251.

trilinos-autotester · 2018-08-08T01:51:27Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

trilinos-autotester · 2018-08-08T01:51:35Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

bartlettroscoe · 2018-08-08T14:13:25Z

@trilinos/framework,

This PR passed testing yesterday and it was approved over 40 minutes ago but the PR tester has yet to mark this as okay to merge. What is up with that? Is this a defect in the PR tester or is the PR tester not running?

jwillenbring · 2018-08-08T14:44:24Z

This PR passed testing yesterday and it was approved over 40 minutes ago but the PR tester has yet to mark this as okay to merge. What is up with that? Is this a defect in the PR tester or is the PR tester not running?

The instance of the autotester that looks at this PR is currently testing another PR, so it will not be looked at again until that PR testing is done.

bartlettroscoe · 2018-08-08T15:00:24Z

The instance of the autotester that looks at this PR is currently testing another PR, so it will not be looked at again until that PR testing is done.

@jwillenbring, okay, then it might be good to update the documentation to warn users that it might take up to 4+ hours or more for the Trilinos PR tester to realize that it is okay to merge after the auto PR builds have passed and approval is submitted.

This means that even if an auto PR tester build does not crash then it could take upwards of 8+ hours or more to allow the merge of a PR even if the PR is approved just after a PR testing iteration is complete. That means that unless you get your PR in very early the morning, then you may not be around to merge it in time for nightly testing the the next day.

trilinos-autotester · 2018-08-08T17:16:29Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ fryeguy52 ]!

trilinos-autotester · 2018-08-08T17:17:08Z

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Master Automerge is disabled (in .cfg file)

trilinos-autotester · 2018-08-08T17:21:05Z

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

bartlettroscoe · 2018-08-08T17:56:36Z

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

@trilinos/framework, has the AT: AUTOMERGE feature been implemented?

allevin · 2018-08-08T18:38:48Z

@bartlettroscoe @trilinos/framework,

Yes, the Automerge feature has been enabled, but the @trilinos/framework team is in the process of testing with a few controlled/monitored PR's. Please refrain from using the AT: AUTOMERGE label until we are satisfied with its operation.

A notification will be sent out when it is available for general usage.

…linos#3251) This also adds back the disables for several SEACAS tests that got removed when the file INTEL-RELEASE-OPENMP.cmake got renamed to the file INTEL-RELEASE-OPENMP-HSW.cmake (not clear how that happened).

Consolidate disables for all builds on 'mutrino' (trilinos#3183)

ec6ffd6

This also adds back the disables for several SEACAS tests that got removed when the file INTEL-RELEASE-OPENMP.cmake got renamed to the file INTEL-RELEASE-OPENMP-HSW.cmake (not clear how that happened).

bartlettroscoe added type: bug The primary issue is a bug in Trilinos code or tests client: ATDM Any issue primarily impacting the ATDM project Disabled Tests Issue has been partially addressed by disabling *all* of the failing tests related to the issue labels Aug 7, 2018

bartlettroscoe added this to the Keep promoted "ATDM" builds of Trilinos clean milestone Aug 7, 2018

bartlettroscoe requested review from gsjaardema and fryeguy52 August 7, 2018 20:34

bartlettroscoe added the stage: in progress Work on the issue has started label Aug 7, 2018

bartlettroscoe mentioned this pull request Aug 7, 2018

New SEACAS tests failing in ATDM Trilinos builds starting on 7/19/2018 and 7/23/2018 #3183

Closed

bartlettroscoe added pkg: seacas and removed Disabled Tests Issue has been partially addressed by disabling *all* of the failing tests related to the issue labels Aug 7, 2018

fryeguy52 approved these changes Aug 8, 2018

View reviewed changes

bartlettroscoe merged commit f93a0cb into trilinos:develop Aug 8, 2018

bartlettroscoe removed the stage: in progress Work on the issue has started label Aug 8, 2018

bartlettroscoe mentioned this pull request Aug 8, 2018

Fix change logic in get-changed-trilinos-packages.sh and PullRequestLinuxDriver.sh (#3133) #3258

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Consolidate disables for all builds on 'mutrino' (#3183) #3251

Consolidate disables for all builds on 'mutrino' (#3183) #3251

bartlettroscoe commented Aug 7, 2018

trilinos-autotester commented Aug 7, 2018

trilinos-autotester commented Aug 7, 2018

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Jenkins Parameters

Using Repos:

trilinos-autotester commented Aug 8, 2018

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Jenkins Parameters

trilinos-autotester commented Aug 8, 2018

trilinos-autotester commented Aug 8, 2018

bartlettroscoe commented Aug 8, 2018

jwillenbring commented Aug 8, 2018

bartlettroscoe commented Aug 8, 2018

trilinos-autotester commented Aug 8, 2018

trilinos-autotester commented Aug 8, 2018

trilinos-autotester commented Aug 8, 2018

bartlettroscoe commented Aug 8, 2018

allevin commented Aug 8, 2018

Consolidate disables for all builds on 'mutrino' (#3183) #3251

Consolidate disables for all builds on 'mutrino' (#3183) #3251

Conversation

bartlettroscoe commented Aug 7, 2018

Description

Motivation and Context

How Has This Been Tested?

Checklist

trilinos-autotester commented Aug 7, 2018

trilinos-autotester commented Aug 7, 2018

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Jenkins Parameters

Using Repos:

trilinos-autotester commented Aug 8, 2018

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

Jenkins Parameters

trilinos-autotester commented Aug 8, 2018

trilinos-autotester commented Aug 8, 2018

bartlettroscoe commented Aug 8, 2018

jwillenbring commented Aug 8, 2018

bartlettroscoe commented Aug 8, 2018

trilinos-autotester commented Aug 8, 2018

trilinos-autotester commented Aug 8, 2018

trilinos-autotester commented Aug 8, 2018

bartlettroscoe commented Aug 8, 2018

allevin commented Aug 8, 2018