Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Piro fix for building with Clang 6 #3248

Merged
merged 2 commits into from
Aug 8, 2018
Merged

Piro fix for building with Clang 6 #3248

merged 2 commits into from
Aug 8, 2018

Conversation

mperego
Copy link
Contributor

@mperego mperego commented Aug 7, 2018

@trilinos/piro @trilinos/rol

Description

Fix for enabling compilation with Clang 6. Added template keyword in Piro::NOXSolves when calling template member function of a Teuchos::ParameterList.
Also fixed a typo in ROL::ThyraProductME_Objective constructor that was generating a warning.

Motivation and Context

Closes issue #3157

How Has This Been Tested?

Checklist

  • My commit messages mention the appropriate GitHub issue numbers.
  • My code follows the code style of the affected package(s).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the code contribution guidelines for this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • No new compiler warnings were introduced.
  • These changes break backwards compatibility.

@bartlettroscoe bartlettroscoe added the stage: in progress Work on the issue has started label Aug 7, 2018
@mperego mperego requested a review from lxmota August 7, 2018 16:45
@mperego mperego added type: bug The primary issue is a bug in Trilinos code or tests pkg: Piro pkg: ROL labels Aug 7, 2018
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

  • Build Num: 1273
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.9.3
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 3248
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA 53e0cd6
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 2b049a2

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 967
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 3248
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA 53e0cd6
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 2b049a2

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 518
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 3248
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA 53e0cd6
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 2b049a2

Using Repos:

Repo: TRILINOS (mperego/Trilinos)
  • Branch: develop
  • SHA: 53e0cd6
  • Mode: TEST_REPO

Pull Request Author: mperego

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

  • Build Num: 1273
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.9.3
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 3248
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA 53e0cd6
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 2b049a2

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 967
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 3248
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA 53e0cd6
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 2b049a2

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 518
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 3248
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA 53e0cd6
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 2b049a2


CDash Test Results for PR# 3248.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@mperego mperego changed the title Develop Piro fix for building with Clang 6 Aug 7, 2018
lxmota
lxmota approved these changes Aug 8, 2018
View reviewed changes
Copy link
Contributor

@lxmota lxmota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Adding missing template keyword that only Clang flagged as an error, and fixing typo in assignment.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ lxmota ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Master Automerge is disabled (in .cfg file)

@mperego mperego merged commit f9de01a into trilinos:develop Aug 8, 2018
@bartlettroscoe bartlettroscoe removed the stage: in progress Work on the issue has started label Aug 8, 2018
@trilinos-autotester trilinos-autotester mentioned this pull request Jan 14, 2021
Merged
@trilinos-autotester trilinos-autotester mentioned this pull request Aug 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lxmota lxmota lxmota approved these changes

Assignees
No one assigned
Labels
pkg: Piro pkg: ROL type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mperego @trilinos-autotester @lxmota @bartlettroscoe