Piro: Compile error with Clang 6 on Linux.

[lxmota]

Piro: Using Clang 6.0.0 on Linux fails to compile with the following error:

In file included from /home/amota/LCM/Trilinos/packages/piro/src/Piro_NOXSolver.
cpp:43:
/home/amota/LCM/Trilinos/packages/piro/src/Piro_NOXSolver_Def.hpp:139:44: error: use 'template' keyword to treat 'get' as a dependent template name
int iteration = optimizationParams.get("Optimizer Iteration Number");
^
template
1 error generated.

@trilinos/piro

Expectations

Piro should compile without error.

Current Behavior

Piro fails to compile.

Motivation and Context

Piro failing to compile prevents Trilinos to compile and install, leading to failure of Albany nightly tests for Clang 6.0.0 under Linux.

Definition of Done

Possible Solution

Steps to Reproduce

Try to compile Trilinos using Clang 6.0.0

Your Environment

• Relevant repo SHA1s:
• Relevant configure flags or configure script:
• Operating system and version:
• Compiler and TPL versions:

Related Issues

• Blocks
• Is blocked by
• Follows
• Precedes
• Related to
• Part of
• Composed of

Additional Information

Albany nightly tests with Clang 6.0.0 started failing on Monday July 16.
For reference on why Albany tests fail: @ikalash @jewatkins

[mperego]

@lxmota There is something weird in your error message.
Line /home/amota/LCM/Trilinos/packages/piro/src/Piro_NOXSolver_Def.hpp:139 is
int iteration = optimizationParams.get<int>("Optimizer Iteration Number");
whereas in your error message you have
int iteration = optimizationParams.get("Optimizer Iteration Number");
Are you building an up-to-date version of Trilinos?

[lxmota]

Yes, the Albany nightly tests pull Trilinos develop every night at midnight and rebuild from scratch. On Jul 20, 2018, at 14:04, mperego <[email protected]<mailto:[email protected]>> wrote: @lxmota<https://github.com/lxmota> There is something weird in your error message. Line /home/amota/LCM/Trilinos/packages/piro/src/Piro_NOXSolver_Def.hpp:139 is int iteration = optimizationParams.get<int>("Optimizer Iteration Number"); whereas in your error message you have int iteration = optimizationParams.get("Optimizer Iteration Number"); Are you building an up-to-date version of Trilinos? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#3157 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AGykgRNUlYgTGfO18YmoP-CVza49EGMEks5uIkXUgaJpZM4VXSyA>.

[lxmota]

Ok, I double checked the last nightly Albany build with Clang. Its from Friday July 20th at midnight. The error is:

In file included from /home/lcm/LCM/Trilinos/packages/piro/src/Piro_NOXSolver.cpp:43:
/home/lcm/LCM/Trilinos/packages/piro/src/Piro_NOXSolver_Def.hpp:139:44: error: use 'template' keyword to treat 'get' as a dependent template name
        int iteration = optimizationParams.get<int>("Optimizer Iteration Number");
                                           ^
                                           template
1 error generated.

I'm not sure how the <int> template parameter got omitted in the original message.

[lxmota]

Once more, I'm not sure why things get truncated. One more try:

In file included from /home/lcm/LCM/Trilinos/packages/piro/src/Piro_NOXSolver.cpp:43:
/home/lcm/LCM/Trilinos/packages/piro/src/Piro_NOXSolver_Def.hpp:139:44: error:
use 'template' keyword to treat 'get' as a dependent template name
        int iteration = optimizationParams.get<int>("Optimizer Iteration Number");
                                           ^
                                           template
1 error generated.

[mhoemmen]

Sometimes GitHub truncates <stuff in here> unless you protect it with backquotes.

[mperego]

Thanks @lxmota for posting the error code again and @mhoemmen for the explanation.

It seems the compiler wants you to put the template keyword at line 139:
int iteration = optimizationParams.template get<int>("Optimizer Iteration Number");

However Trilinos is full of these getters with no template keyword. Maybe it is the auto that's messing things up..

@lxmota if it is not too much trouble, can you try the solution above, or to replace the auto at lines 135 and 137 with const Teuchos::ParameterList& ?

[mperego]

Closing the issue as it issue should have been resolved.