Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MueLu: fix #2664 for std::complex using a cast in parameter list #2675

Merged
merged 2 commits into from
May 3, 2018
Merged

MueLu: fix #2664 for std::complex using a cast in parameter list #2675

merged 2 commits into from
May 3, 2018

Conversation

lucbv
Copy link
Contributor

@lucbv lucbv commented May 3, 2018

This commit provides a simple fix to the error in the BlockedRepartition
unit test when std::complex is on. This should remove the last error on the
dashboard related to PR #2561

@trilinos/muelu

Description

Simple cast of value in parameter list from double to SC ensuring proper type for std::complex builds

Motivation and Context

This fixes a failing test

Related Issues

How Has This Been Tested?

The test suite of MueLu was run with -D Trilinos_ENABLE_COMPLEX:BOOL=ON to make sure that the test now passes for complex builds

Checklist

  • My commit messages mention the appropriate GitHub issue numbers.
  • My code follows the code style of the affected package(s).
  • I have read the code contribution guidelines for this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • No new compiler warnings were introduced.

@lucbv
MueLu: fix trilinos#2664 for std::complex using a cast in parameter list
2189d2a 
This commit provides a simple fix to the error in the BlockedRepartition
unit test when std::complex is on. This should remove the last error on the
dashboard related to PR trilinos#2561
@lucbv lucbv added type: bug The primary issue is a bug in Trilinos code or tests pkg: MueLu labels May 3, 2018
@lucbv lucbv self-assigned this May 3, 2018
@lucbv lucbv requested review from csiefer2 and jhux2 May 3, 2018 17:18
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

  • Build Num: 597
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.9.3
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2675
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_fix_2664_std_complex
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 2189d2a
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 07ae065

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 314
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2675
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_fix_2664_std_complex
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 2189d2a
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 07ae065

Using Repos:

Repo: TRILINOS (lucbv/Trilinos)
  • Branch: MueLu_fix_2664_std_complex
  • SHA: 2189d2a
  • Mode: TEST_REPO

Pull Request Author: lucbv

aprokop
aprokop reviewed May 3, 2018
View reviewed changes
Copy link
Contributor

@aprokop aprokop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Teuchos::as<SC>(1.0)?

jhux2
jhux2 previously requested changes May 3, 2018
View reviewed changes
Copy link
Member

@jhux2 jhux2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as @aprokop.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

  • Build Num: 597
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.9.3
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2675
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_fix_2664_std_complex
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 2189d2a
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 07ae065

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 314
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2675
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_fix_2664_std_complex
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 2189d2a
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 07ae065


CDash Test Results for PR# 2675.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS BEEN REVIEWED, BUT NOT ACCEPTED OR REQUIRES CHANGES

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@lucbv
Copy link
Contributor Author

lucbv commented May 3, 2018

@jhux2 fixed the issue @aprokop pointed out

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

  • Build Num: 601
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.9.3
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2675
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_fix_2664_std_complex
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 4d08868
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 07ae065

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 318
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2675
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_fix_2664_std_complex
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 4d08868
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 07ae065

Using Repos:

Repo: TRILINOS (lucbv/Trilinos)
  • Branch: MueLu_fix_2664_std_complex
  • SHA: 4d08868
  • Mode: TEST_REPO

Pull Request Author: lucbv

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

  • Build Num: 601
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.9.3
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2675
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_fix_2664_std_complex
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 4d08868
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 07ae065

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 318
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2675
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_fix_2664_std_complex
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 4d08868
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 07ae065


CDash Test Results for PR# 2675.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ mhoemmen ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Master Automerge is disabled (in .cfg file)

@aprokop aprokop dismissed jhux2’s stale review May 3, 2018 22:19

was addressed.

@aprokop aprokop merged commit d6cb398 into trilinos:develop May 3, 2018
@lucbv lucbv deleted the MueLu_fix_2664_std_complex branch May 3, 2018 23:20
@lucbv lucbv mentioned this pull request May 4, 2018
Merged
6 tasks
@trilinos-autotester trilinos-autotester mentioned this pull request Jun 10, 2021
Closed
@trilinos-autotester trilinos-autotester mentioned this pull request May 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aprokop aprokop aprokop left review comments

@mhoemmen mhoemmen mhoemmen approved these changes

@jhux2 jhux2 jhux2 left review comments

@csiefer2 csiefer2 Awaiting requested review from csiefer2

Assignees

@lucbv lucbv

Labels
pkg: MueLu type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lucbv @trilinos-autotester @mhoemmen @aprokop @jhux2