Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MueLu: blocked repartitioning fails to build in serial and with complex #2664

Closed
1 task done
lucbv opened this issue May 2, 2018 · 2 comments
Closed
1 task done

MueLu: blocked repartitioning fails to build in serial and with complex #2664

lucbv opened this issue May 2, 2018 · 2 comments
Assignees
@lucbv
Labels
pkg: MueLu type: bug The primary issue is a bug in Trilinos code or tests

Comments

@lucbv
Copy link
Contributor

lucbv commented May 2, 2018 •
edited
Loading

@trilinos/muelu
@csiefer2

Expectations

We should fix the MueLu::RepartitionBlockDiagonalFactory factory to have it build correctly in serial

Current Behavior

This build fails in the clean track and we should fix it.

Motivation and Context

The clean track should be clean...

Definition of Done

  • Build with same config as clean build and make sure no errors appear.

Possible Solution

I am guessing that something ETI related is blocking this build but further investigation is required.

Steps to Reproduce

Just look at the config for the failing build on the dashboard to reproduce the error.
@lucbv lucbv added type: bug The primary issue is a bug in Trilinos code or tests pkg: MueLu labels May 2, 2018
@lucbv lucbv self-assigned this May 2, 2018
@lucbv lucbv mentioned this issue May 2, 2018
Merged
6 tasks
@lucbv
Copy link
Contributor Author

lucbv commented May 2, 2018

The serial and Tpetra only builds are now linking fine #2666 seems to have fixed this issue.
I will close this tomorrow if the dashboard is clean.

@lucbv
Copy link
Contributor Author

lucbv commented May 3, 2018

Trilinos is now building fine in serial but there is still a failing test with std::complex due to a parameter list input. Hopefully a simple type casting should fix that, testing a complex build before doing a new PR.

@lucbv lucbv mentioned this issue May 3, 2018
Merged
6 tasks
aprokop added a commit that referenced this issue May 3, 2018
@aprokop
Merge pull request #2675 from lucbv/MueLu_fix_2664_std_complex
d6cb398 
MueLu: fix #2664 for std::complex using a cast in parameter list
@lucbv lucbv changed the title MueLu: blocked repartitioning fails to build in serial MueLu: blocked repartitioning fails to build in serial and with complex May 4, 2018
This was referenced May 23, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucbv lucbv

Labels
pkg: MueLu type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lucbv