New Driver script and intel config file for PR testing #2606
Conversation
prwolfe
added
the
Framework tasks
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Using Repos:
Pull Request Author: prwolfe |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
2 similar comments
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
|
@bartlettroscoe I did not see your request for scotch before I set this up. Sierra could use that as well, but since it doesn't run in the gcc PR builds I think we should have that as a follow-on discussion. |
There was a problem hiding this comment.
The PullRequestLinuxIntelTestingSettings.cmake file and PullRequestLinuxGCCTestingSettings.cmake files are identical. It seems we should have a single file and call it PullRequestLinuxTestingSettings.cmake. We may need a separate one for CUDA possibly, but we could start for now with a single file at least. If we can have a common file for all or most builds, that would be positive.
In the two remaining files there are references to gcc/GCC that should be changed to Intel.
Correction: The driver file just needs to point to the single combined file. There are not other references to GCC that need to be changed.
|
I think there needs to be a different *.cmake file for each specific build in order to allow setting targeted test disables for those builds. You have to be able to (temporarily) disable a test if needed. For example, it looks like the Intel 17.0.1 build needs some cleaning up (see #2463 (comment)). There would be almost no clean ATDM Trilinos builds if we required fixing every test before the build was promoted. |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
|
@bartlettroscoe That is in fact a good part of why I had a second file. And those failures are why I didn't send in a pull request to enable this yet. All of those tests should be easy to clean up except possibly the kokkos one, so I would favor fixing rather than disabling. |
|
@prwolfe, having a separate file for each build is good. Duplicating every var is not good. A system of
Those outer files (which are just a few lines long) could be copied to |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Using Repos:
Pull Request Author: prwolfe |
|
The variable was an attempt on my part to get the sims modules to load without the error. Turns out that despite referencing this the intel module then ignores it and hard code 4.8.4 as the default so we alway s get the warning message. I will get it out of the script and clean up the comments. |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
Note that this will not yet enable the intel build as the autotester does not yet have the configuration. It just provides the files needed.
|
@jwillenbring - I fixed up that environment script. I will take a look at the failing tests. I don't want to turn this on without those resolved. |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Using Repos:
Pull Request Author: prwolfe |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ jwillenbring ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Master Automerge is disabled (in .cfg file) |
@trilinos/framework
Motivation and Context
Note that this will not yet enable the intel build as
the autotester does not yet have the configuration. It
just provides the files needed.
Related Issues
How Has This Been Tested?
I set up an autotesterinstance pointed at my fork and created a PR from this branch to develop on my fork. The results can be seen at prwolfe#2 and https://testing-vm.sandia.gov/cdash/index.php?project=Trilinos&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercombine=and&filtercount=2&showfilters=1&filtercombine=and&field1=buildname&compare1=63&value1=PR-2-test&field2=buildstarttime&compare2=84&value2=NOW